Effect is a keyword in ocaml 5.3

[wmuth]

TLDR

I was compiling the project using Ocaml 5.3.0 and got some syntax errors. Currently the easiest fix is to rename the variables causing the issues from effect to side_effect since they represent a boolean which in turn represents whether something has side effects.

Explaination

In Ocaml 5.3.0 the effect keyword was added, see the release here.

A couple places in the /src/boot project uses effect as a variable name and hence the project does not compile using Ocaml 5.3.0.

With 5.3.0 a -keywords flag was added and appending -keywords 5.2 to the compilation flags would avoid this issue. See this PR. However, since boot is compiled using dune this is not currently possible. This is because when I ran dune b --verbose I discovered that dune runs ocamldep first which throws the syntax error and dune does not currently have the ability to pass flags to ocamldep. See this issue. Ocamldep does support the -keywords flag on the newest development branches, however, this was added in this PR. That PR was after the release of 5.3.0 and so ocamldep 5.3.0 does not support the -keywords flag. And even if it did, like mentioned earlier, dune does not currently support sending flags to ocamldep.

[wmuth]

Closed due to accidentally adding commits to this PR instead of a separate PR