Auto-promote JsonInt to Float when deserializing #928
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Json doesn't distinguish between
IntandFloat, it only has numbers, but ourjsonlibrary does (to be more convenient with the rest of the system). This means that something that looks like anInt(no fractional part) will be parsed toJsonInteven if our program expected aFloatin that position. The easiest way to deal with this is to let the deserialization function used after parsing (jsonDeserializeFloat) automatically promote toFloatif it encounters aJsonInt.