Demote recursive using free variables instead of call graph #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
demote-recursive.mcto be slightly simpler, it only looks at free variables in bodies of arecursive letto determine dependencies instead of using a call graph viacall-graph.mc. This fixes a bug where a partial application did not induce a dependency. I don't actually understand why this bug existed before,call-graph.mcdoesn't seem to look at applications and should thus not be able to distinguish between a partial and full application, but this change makesdemote-recursive.mcmildly simpler and fixes the bug, so I figure it's desirable even without a full understanding of the original cause.