-
Notifications
You must be signed in to change notification settings - Fork 36
Test script checks existance of mi #935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
elegios
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that someone is looking at these scripts with an outside perspective. I'd be a bit cautious of automatically and implicitly doing things that aren't the main task of each script. Instead, I'd prefer to either give an informative error message or an explicit confirmation dialog.
|
I could put all the installs behind y/N prompts. Of course it could also just print error messages but I personally much preferred the script having the ability to also perform the needed change, but I see your point about asking the user before doing anything. EDIT: Should I add a For the Tup part, potentially I could move the checks to happen after the check wether to use tup or make as the test-runner? In that case the command/file exists check would only be run if we are using make and can't use tup's versions of the binaries. And of coure it can ask the user before actually running the make targets. |
|
I think asking before running another |
|
Merging this PR closes #927 . |
TLDR: This PR addresses issue #927
make cheatimplicitly relied oninstallsince it just calledmi, made the dependency explicitmisc/test-utils.shfor containing extra logic to not bloat upmisc/test. The file contains logic for checking which mi version the user requested and making sure it exists.misc/testsourcestest-utils.shand calls the function inside of it.