Feat: Add -j flag to test script and have make & tup obey it #940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnwikman
reviewed
Apr 2, 2025
johnwikman
approved these changes
Apr 2, 2025
wmuth
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parallelization to the test script
misc/testusing a-jflag the same waymakeandtuphas.Parallelization is disabled by default and is enabled using the
-j%dflag. If you provide-jwithout a number then the script automatically detects your number of logical cpu cores and automatically runs that many jobs in parallel.Before this PR, running
make test -j%d, would run the tests in parallel since recursivemakeinvocations inherit flags trough theMAKEFLAGSenvironment variable. This still works but nowtupalso follows the specified-jflag, even if provided tomaketrough e.g.make test -j5.