-
Notifications
You must be signed in to change notification settings - Fork 36
Miking Meeting Notes 2025
Note-taker: Oscar Eriksson
Participants: John Wikman, David Broman, Lars Hummelgren, Oscar Eriksson, Gizem Caylak, Viktor Palmqvist, Tim Virgoulay
PRs
- Tim (presented by Viktor): https://github.com/miking-lang/miking-dppl/pull/215
- We like
Discussions We discussed returning a system F representation from the type checker to make it easier to preserve types in transformations after type-checking. We agreed that this would be a good idea, but we left it for the future.
Note-taker: John Wikman
Participants: John Wikman, David Broman, Lars Hummelgren, Oscar Eriksson
PRs
- Lars: https://github.com/miking-lang/miking/pull/962
- We like
- Lars: https://github.com/miking-lang/miking/pull/963
- We like
- Lars: https://github.com/miking-lang/miking-dppl/pull/214
- We like
Discussions
- Oscar: The possibility of using a float2uniquestring with a specified precision. This should be used for unique representations on floats in codegen. Should have the property of being the identity function when composed with string2float.
Note-taker: Viktor Palmkvist
Participants: Viktor Palmkvist, David Broman, Lars Hummelgren, John Wikman, Anders Ågren Thuné, Oscar Eriksson
PRs
- Lars: https://github.com/miking-lang/miking-dppl/pull/212
- We like
- Lars: https://github.com/miking-lang/miking/pull/961
- We like
- Oscar: https://github.com/miking-lang/miking-dppl/pull/213
- We like
Note-taker: Gizem Caylak
Participants: Viktor Palmkvist, Gizem Caylak, David Broman, Lars Hummelgren, John Wikman, Erik Danielsson
PRs
- Erik: https://github.com/miking-lang/miking-dppl/pull/211
- We liked it, but fix the error first (talking to Oscar) and ping David
- Viktor: https://github.com/miking-lang/miking/pull/957
- We liked, merge
- Viktor: https://github.com/miking-lang/miking/pull/958
- We liked but add tests, then ping David.
- Viktor: https://github.com/miking-lang/miking/pull/959
- We liked, merge
- Lars: https://github.com/miking-lang/miking/pull/960
- We liked, merge
Note-taker: Viktor Palmkvist
Participants: Viktor Palmkvist, Oscar Eriksson, Gizem Caylak, David Broman, Lars Hummelgren, Martin Zivojinovic
PRs
- Martin: https://github.com/miking-lang/miking/pull/956
- Check effect on bootstrapping time
- Change some
switches tosemfunctions - Change
sonstochildren - Then we like
- For later
-
Code...->Show Implementation -
Tests...->Show Tests - Look into getting a file and its language fragments as a folder and sub-entries when it's presented in Docusaurus
- Flag to not include
Codein the generated documentation - Some way to include markdown in comments (flag? marker in the file?)
-
- Martin: https://github.com/miking-lang/miking-lang.github.io/pull/36
- We will wait to merge this for further updates to the generator, but it's looking very promising
Note-taker: Oscar Eriksson
Participants: Lars Hummelgren, Viktor Palmkvist, Oscar Eriksson, John Wikman, David Broman
We merged https://github.com/miking-lang/miking/pull/955 and briefly discussed when we should get started with the Miking paper again.
Note-taker: John Wikman
Participants: Lars Hummelgren, Viktor Palmkvist, Oscar Eriksson, Anders Ågren Thuné, Wiktor Dobrosierdow, John Wikman
Wiktor Dobrosierdow presented his proof-of-concept implementation for externals:
Note-taker: Viktor Palmkvist
Participants: Lars Hummelgren, Viktor Palmkvist, Gizem Çaylak, Oscar Eriksson, Anders Ågren Thuné, Erik Danielsson
Pull Request
- Erik: https://github.com/miking-lang/miking/pull/953
- We like
- Erik: https://github.com/miking-lang/miking-dppl/pull/210
- We like
- Viktor: https://github.com/miking-lang/miking/pull/951
- We like
- Viktor: https://github.com/miking-lang/miking-dppl/pull/209
- We like
- Viktor: https://github.com/miking-lang/mi-ocaml/pull/7
- We like
Suggested test and merge queue: mi/950 mi/951,dppl/209,mi-ml/7,tppl/105 mi/953,dppl/210
(950 was previously accepted, but hasn't been merged yet)
Note-taker: Lars Hummelgren
Participants: Lars Hummelgren, John Wikman, Viktor Palmkvist, Tim Virgoulay, Martin Zivojinovic, Gizem Çaylak
Pull Request
- Viktor
-
https://github.com/miking-lang/miking/pull/951
- Decl rewrite, will look at examples next time David joins
-
https://github.com/miking-lang/miking-dppl/pull/209
- Fixes in Miking DPPL based on #951
-
https://github.com/miking-lang/mi-ocaml/pull/7
- Updates to make mi-ocaml work again
- Needed because of previous changes (i.e., not only #951)
-
https://github.com/miking-lang/miking/pull/951
Discussion
- Martin presented his work on creating documentation.
Note-taker: Gizem Çaylak
Participants: Gizem Çaylak, David Broman, John Wikman, Viktor Palmkvist, Oscar Eriksson, Tim Virgoulay, Martin Zivojinovic
Pull Request
-
Viktor
-
https://github.com/miking-lang/miking/pull/950
- We like, merge
-
https://github.com/miking-lang/miking-dppl/pull/207
- Once 950 merged, this one needs to be updated (currently, pointing to Viktor's git fork). Viktor will ping.
-
https://github.com/miking-lang/miking/pull/950
-
Gizem
-
https://github.com/miking-lang/miking-dppl/pull/208
- We liked, merge
-
https://github.com/miking-lang/miking-dppl/pull/208
Discussion
- Martin demonstrated his initial implementation to create documentation.
Note-taker: Oscar Eriksson
Participants: Gizem Çaylak, Lars Hummelgren, David Broman, John Wikman, Viktor Palmkvist, Oscar Eriksson, David Broman
Pull Request
- Viktor
-
https://github.com/miking-lang/miking/pull/949
- We like, merge.
-
https://github.com/miking-lang/miking-dppl/pull/206
- We like, merge after Miking PR 949.
-
https://github.com/miking-lang/miking/pull/949
Discussion
- Viktor demonstrated a script that generates Dockerfiles from installations instructions written in markdown.
- We discussed packaging of Miking and its related DSLs, in particular TreePPL. We discussed separating it into system packages for Miking and a PIP package for TreePPL, or bundling everything into a PIP package.
Note-taker: Gizem Çaylak
Participants: Gizem Çaylak, Lars Hummelgren, David Broman, John Wikman, Viktor Palmkvist, Oscar Eriksson
Pull Request
- Viktor: https://github.com/miking-lang/miking/pull/948
- We like, merge
- Viktor: https://github.com/miking-lang/miking/pull/947
- We like, merge
- Viktor: https://github.com/miking-lang/miking/pull/946
- We like, merge
Note-taker: Viktor Palmkvist
Participants: Gizem Çaylak, Tim Virgoulay, Lars Hummelgren, David Broman, John Wikman, Viktor Palmkvist
Pull Request
- Tim: https://github.com/miking-lang/miking/pull/944
- We like
- Tim: https://github.com/miking-lang/miking-dppl/pull/202
-
DsNegDistBinomial->DsDistNegBinomial. Wait with the change until we have tests that can catch this. - Then we like
-
- Tim: https://github.com/miking-lang/miking-dppl/pull/203
- We like, but includes 202, so it will likely need rebasing after that
- Gizem: https://github.com/miking-lang/miking/pull/945
- Move
linspaceto math, then we like
- Move
- Gizem: https://github.com/miking-lang/miking-dppl/pull/204
- We like
- Gizem: https://github.com/miking-lang/miking-dppl/pull/205
- We like
- Viktor: https://github.com/miking-lang/miking-dppl/pull/200
- We like
- Viktor: https://github.com/miking-lang/miking-dppl/pull/201
- Viktor needs to make some updates, then we like
Discussion
- Tim would like to sort distributions by name in the files they're defined in. We like this idea.
- Tim would also like to look into consistency of naming of distribution parameters, and probably make a proposal for renaming consistently.
Note-taker: John Wikman
Participants: David Broman, Viktor Palmkvist, Benjamin Lion, Tim Virgoulay, Anders Ågren Thuné, Lars Hummelgren, Oscar Eriksson, John Wikman, Gizem Çaylak
Pull Request
- Viktor
-
https://github.com/miking-lang/miking/pull/941
- We like!!
-
https://github.com/miking-lang/miking/pull/942
- Add some info about the performance impact of this. Then we like if the impact is insignificant.
-
https://github.com/miking-lang/miking/pull/943
- We like, but make sure that this behavior is well documented.
- Used by miking-dppl#198
-
https://github.com/miking-lang/miking/pull/941
- Gizem
-
https://github.com/miking-lang/miking-dppl/pull/199
- We like, merge before miking-dppl#198
-
https://github.com/miking-lang/miking-dppl/pull/199
- Viktor
Discussion
Anders showed a demo of a type-correct translation of MExpr to OCaml. Also showed a demo of copatterns on records.
Note-taker: Lars Hummelgren
Participants: Gizem Çaylak, David Broman, Lars Hummelgren, Tim Virgoulay, John Wikman, William Muth, Oscar Eriksson, Anders Ågren Thuné
Pull Request
- John
- William
-
https://github.com/miking-lang/miking/pull/939
- We like
-
https://github.com/miking-lang/miking/pull/940
- Pass
-jflag to Tup, then we like
- Pass
-
https://github.com/miking-lang/miking/pull/939
- Viktor
Note-taker: Viktor Palmkvist
Participants: Gizem Çaylak, David Broman, Lars Hummelgren, Tim Virgoulay, John Wikman, William Muth, Oscar Eriksson
Pull Request
- Gizem: https://github.com/miking-lang/miking-dppl/pull/196
- We like
- William: https://github.com/miking-lang/miking/pull/934
- We like
- William: https://github.com/miking-lang/miking-lang.github.io/pull/35
- Remove instead of comment out, then we like
- William: https://github.com/miking-lang/miking-lang.github.io/pull/34
- Update node version in github action, then we like
- William: https://github.com/miking-lang/miking/pull/935
- Make interactive the default, have
make test-allrun in non-interactive mode, then we like
- Make interactive the default, have
- Viktor: https://github.com/miking-lang/miking/pull/936
- We like
From last meeting, but wasn't in the meeting notes
- Viktor: https://github.com/miking-lang/miking/pull/932
- We like
Discussion:
When the test suite has a test case that is expected to fail and does indeed fail it prints "FAIL", which can be interpreted as " the test failed, which is a thing we don't want". William will make an issue.
Note-taker: John Wikman
Participants: Gizem Çaylak, Viktor Palmkvist, William Muth, Oscar Eriksson, Lars Hummelgren, John Wikman, Anders Ågren Thuné, David Broman
Pull Request
- Oscar:
-
https://github.com/miking-lang/miking-dppl/pull/195
- We like, merge
-
https://github.com/miking-lang/miking-dppl/pull/195
- William:
-
https://github.com/miking-lang/miking/pull/925
- We like, merge
-
https://github.com/miking-lang/miking/pull/926
- We like, but need an extra PR afterwards to fix the git ignore commit.
- Also the lint should be added to the make test.
- Ping David when these are done.
-
https://github.com/miking-lang/miking-lang.github.io/pull/33
- We like, merge
-
https://github.com/miking-lang/miking/pull/925
- Viktor:
-
https://github.com/miking-lang/miking/pull/928
- We like, merge
-
https://github.com/miking-lang/miking/pull/931
- We like, merge
-
https://github.com/miking-lang/miking/pull/930
- We like, merge
-
https://github.com/miking-lang/miking/pull/928
- John:
-
https://github.com/miking-lang/miking/pull/929
- We like, merge
- Need to update the documentation to not refer to ipopt anymore.
-
https://github.com/miking-lang/miking/pull/933
- We like the updates to bool.mc and sys.mc, but split the update to test-spec.mc into a separate PR.
- Ping David once this is done, then merge.
-
https://github.com/miking-lang/miking/pull/929
Note-taker: Lars Hummelgren
Participants: Lars Hummelgren, Tim Virgoulay, David Broman, John Wikman, Viktor Palmkvist, Oscar Eriksson, Gizem Çaylak
Pull Request
- Viktor:
- ProbTime: https://github.com/miking-lang/ProbTime/pull/4
- We decided not to merge this but keep it as a draft
- Merge the following two PRs together:
- ProbTime: https://github.com/miking-lang/ProbTime/pull/4
- Oscar:
-
https://github.com/miking-lang/miking/pull/919
- We like, merge
-
https://github.com/miking-lang/miking/pull/920
- We like, merge
-
https://github.com/miking-lang/miking/pull/919
- Viktor:
- https://github.com/miking-lang/miking/pull/921
-
https://github.com/miking-lang/miking-dppl/pull/194
- We like, merge the above two together
-
https://github.com/miking-lang/miking/pull/922
- We like, merge
-
https://github.com/miking-lang/miking/pull/923
- We like, merge
Note-taker: Oscar Eriksson
Participants: Lars Hummelgren, Gizem Çaylak, Viktor Palmkvist, John Wikman, Oscar Eriksson, Tim Virgoulay, Erik Danielsson, David Broman.
Pull Request
- Viktor, should be merged from top to bottom.
-
https://github.com/miking-lang/miking/pull/911
- We like, merge.
-
https://github.com/miking-lang/miking/pull/912
- We like, merge.
-
https://github.com/miking-lang/miking/pull/914
- We like, merge.
-
https://github.com/miking-lang/miking/pull/915
- We like, merge.
-
https://github.com/miking-lang/miking/pull/916
- We like, merge.
-
https://github.com/miking-lang/miking/pull/917
- We like, merge.
-
https://github.com/miking-lang/miking/pull/918
- We like, merge.
-
https://github.com/miking-lang/miking/pull/913
- Add test, then we like merge.
-
https://github.com/miking-lang/miking-dppl/pull/192
- We like, merge. It should be merged with 898.
-
https://github.com/miking-lang/miking/pull/911
Note-taker: Gizem Caylak
Participants: Lars Hummelgren, Gizem Çaylak, Viktor Palmkvist, John Wikman, Oscar Eriksson, Didrik Munther
Pull Requests
- William: https://github.com/miking-lang/miking-dppl/pull/193
- We like, merge.
- Erik: https://github.com/miking-lang/miking/pull/907
- We like, merge.
- Oscar: https://github.com/miking-lang/miking/pull/908
- We like, merge
- Viktor P.: https://github.com/miking-lang/miking/pull/909
- We like, merge
- Didrik : https://github.com/miking-lang/miking/pull/906
- We like but need to fix the issues discussed in the meeting. Ping David.
Note-taker: Viktor Palmkvist
Participants: Tim Virgoulay, Lars Hummelgren, David Broman, Gizem Çaylak, Viktor Palmkvist, John Wikman, Oscar Eriksson, Didrik Munther, William Muth
Pull Requests
- William: https://github.com/miking-lang/miking/pull/905
- We like. Also change the same file in miking-lang/miking-dppl.
- Marten: https://github.com/miking-lang/miking/pull/882
- Now updated for the new build system, we like.
- Didrik: https://github.com/miking-lang/miking/pull/906
- Make readBytesBuffered tail-recursive, then we like. (DONE)
Discussion
New script for testing multiple repositories at once seems promising, make it output the PR-groups to the log, then experiment with automatically committing and pushing to a repository when the run has completed.
Note-taker: Oscar Eriksson
Participants: Tim Virgoulay, Lars Hummelgren, Viktor Palmkvist, John Wikman, Oscar Eriksson, David Broman, Gizem Çaylak
Pull Requests
- Gizem:
-
https://github.com/miking-lang/miking/pull/903
- We like, merge.
-
https://github.com/miking-lang/miking/pull/903
Old PRs left to merge
- Miking: 876
- Miking-DPPL: 189
Discussion
We discussed microbenchmarks for external arrays. We should switch from Tensor to external array-based vectors and matrices, although this does not solve all performance problems. We need to look into how we generate OCaml code to be on par with OCaml. We will start by implementing a Bigarrays-based matrix library and move to using that library instead of tensors in coreppl/treeppl. We should also remove tensors from the documentation.
Note-taker: John Wikman
Participants: Tim Virgoulay, Lars Hummelgren, Viktor Palmkvist, John Wikman, Oscar Eriksson, Anders Ågren Thuné, David Broman
Pull Requests
- Viktor:
-
https://github.com/miking-lang/miking/pull/897
- We like
-
https://github.com/miking-lang/miking/pull/898
- We like
-
https://github.com/miking-lang/miking/pull/899
- We like
-
https://github.com/miking-lang/miking/pull/900
- Add a named variable for the magic constant 4. Then we like.
-
https://github.com/miking-lang/miking/pull/902
- We like, but there is a discussion to be had how we should treat Ref and Symbol compared to Int, Float, etc. Should we have a TySymbol AST node or should all be created as TyCon? Add it as a separate issue.
-
https://github.com/miking-lang/miking/pull/901
- (Includes all the PRs above)
- Now there is a generate-utest.mc, in addition to utest-generate.mc. Should aim to remove utest-generate.mc in the future when we can.
- On a separate note, would also be good to have a test that checks that utest are actually running.
- Viktor need to remove some debugging things, then we like.
-
https://github.com/miking-lang/miking-dppl/pull/192
- We discussed this PR, but there are still things to be done. Will present again at a later date when it is ready.
-
https://github.com/miking-lang/miking/pull/897
Note-taker: Viktor Palmkvist
Participants: Lars Hummelgren, Oscar Eriksson, Viktor Palmkvist, Tim Virgoulay, John Wikman, Gizem Çaylak, David Broman, Anders Ågren Thuné
Pull Requests
- Tim: https://github.com/miking-lang/miking-dppl/pull/191
- Implement fallback to prior distributino if no explicit drift-kernel is supported. Add a test that is fast and included in normal test suite, but is much less precise. Also fix Oscar's comment. Then we like.
- Oscar: https://github.com/miking-lang/miking/pull/896
- We like
Discussions Proposal: remove tensors as a built-in part of the language. Refactor or remove dependent code, primarily shifting to use externals that implement vectors and matrixes directly. Oscar can write that library.
Note-taker: Lars Hummelgren
Participants: Lars Hummelgren, Oscar Eriksson, Viktor Palmkvist, Anders Ågren Thuné, Tim Virgoulay, John Wikman, Gizem Çaylak
Pull Requests
- Viktor
-
https://github.com/miking-lang/miking/pull/889
- Wait until we know how it conflicts with PR 882
-
https://github.com/miking-lang/miking/pull/891
- Add at least one test for
avlIntersectWithKey, then we like
- Add at least one test for
-
https://github.com/miking-lang/miking/pull/894
- Looks good, but we would like to know about the performance diff
- https://github.com/miking-lang/miking/pull/888
- https://github.com/miking-lang/miking/pull/890
- https://github.com/miking-lang/miking/pull/892
- https://github.com/miking-lang/miking/pull/893
-
https://github.com/miking-lang/miking/pull/895
- We like, merge
-
https://github.com/miking-lang/miking/pull/889
Discussions
- https://github.com/miking-lang/miking/pull/876 and the corresponding one in DPPL https://github.com/miking-lang/miking-dppl/pull/189 are ready to be merged (they were presented in November, though the DPPL one is not in the notes).