Support multiple font families in font handling #856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored font-family property to use StringList instead of String, allowing for multiple font families to be specified and tried in order. Updated ComputeFontFamily and related interfaces to handle lists, and added logic to FontEngineInterface to select the first available font from a list. Updated tests to use multiple font families.
Owner
|
Hi, and thanks for making a pull request! Can you elaborate on the motivation behind this change? The assumption generally for the library is that users are in control of their environment. This includes being aware of which fonts they load and making available. Thus, a missing font face is considered an error. There has been some discussion around multiple font families earlier, here in the context of fallback fonts: #500 |
Author
|
Honestly.. i tried the Syntax.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored font-family property to use a list of font families instead of a single string. Updated related interfaces and logic to iterate through font families and select the first available font. Adjusted tests to use multiple font families in style definitions.