Fix compile issues in the SVG plugin when using a non-std string type
#872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few compile issues related to the use of
std::stringwhere aRml::Stringis expected (or the opposite).In SVGCache.cpp, I applied the same changes as in #820, since they got overwritten by #777. I also added an explanatory comment.
Also note that the samples and benchmarks don't compile when
Rml::Stringis notstd::string. I can add the fix for the samples in this PR if needed, I put the patch below.For the benchmarks I don't know if it's necessary to fix them, as I wouldn't expect people to run them with a non-std string type. Afaict it's just that the
bench.run(name, ...)function expects astd::stringbut is passed anRml::String.Patch for the samples