Skip to content

Don't destroy engine when current file is outside project before tryi… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't destroy engine when current file is outside project before tryi… #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92fb8af
Don't destroy engine when current file is outside project before tryi…
Nov 15, 2018
250d9b7
Actually, just need to not destroy the engine and everything works fine
Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions python/tk_houdini/ui_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,10 +961,15 @@ def _on_file_change_timeout():
try:
tk = sgtk.tank_from_path(cur_file)
except sgtk.TankError, e:
# Unable to get tk api instance from the path. won't be able to get a
# new context. if there is an engine running, destroy it.
if cur_engine:
cur_engine.destroy()

# Unable to get tk api instance from the path. Try to get a
# new context with pick_environmet.
if cur_engine:
try:
sgtk.platform.engine.get_environment_from_context(cur_engine.sgtk, cur_context)
except sgtk.TankError, e:
# Unable to get anycontext. if there is an engine running, destroy it.
cur_engine.destroy()
return

# get the new context from the file
Expand Down