Skip to content

Adding link to eigen directories#778

Open
kmader wants to merge 1 commit intomil-tokyo:masterfrom
kmader:patch-2
Open

Adding link to eigen directories#778
kmader wants to merge 1 commit intomil-tokyo:masterfrom
kmader:patch-2

Conversation

@kmader
Copy link

@kmader kmader commented Feb 12, 2018

adding link to eigen3 path to hopefully address this issue

adding link to eigen3 path
@Kiikurage Kiikurage requested a review from milhidaka February 26, 2018 03:35
@milhidaka
Copy link
Member

Thank you for the pull request.
I would like to ask two updates.
First, allow users to override include path because eigen is not necessarily in /usr/include/eigen3.
In brew, it is installed in /usr/local/include/eigen3.
So, please add override option like:

generate(graph, include_path=["/usr/local/include/eigen3","/some/other/path"])
=> args.append("-I/usr/local/include/eigen3"), args.append("-I/some/other/path")

If there is include_path item in kwargs, it should be used. If it is not, default (/usr/include/eigen3) should be used.

Second, your patch only applies to _compile_fallback_asmjs, but should also applies to _compile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants