Split fetch and parse for jobs #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soline-b
commented
Nov 3, 2025
sarc/core/scraping/jobs.py
Outdated
| value=get_jobs(clusters[cluster_name], time_from, time_to)) | ||
|
|
||
| if auto_interval is not None: | ||
| set_auto_end_time(cluster_name, auto_end_field, time_to) |
Collaborator
Author
There was a problem hiding this comment.
Préfère-t-on appeler set_auto_end_time lors du parse ?
soline-b
commented
Nov 3, 2025
sarc/cli/parse/jobs.py
Outdated
| clusters_cfg = config("scraping").clusters | ||
| assert clusters_cfg is not None | ||
|
|
||
| parse_jobs(self.cluster_names, clusters_cfg, self.from_) |
Collaborator
Author
There was a problem hiding this comment.
L'ajout à MongoDB se fait pour l'instant dans la fonction parse_jobs. Préfère-t-on le faire directement ici (avec un parse_jobs qui retourne une liste de jobs) ?
Collaborator
There was a problem hiding this comment.
Je crois que c'est bien correct avec un parse_jobs.
soline-b
commented
Nov 3, 2025
|
|
||
| def execute(self) -> int: | ||
|
|
||
| clusters_cfg = config("scraping").clusters |
Collaborator
Author
There was a problem hiding this comment.
Ici, clusters_cfg est récupéré à partir " config("scraping"). Souhaite-t-on faire un fichier de configuration pour le parsing ?
Collaborator
There was a problem hiding this comment.
C'est quelque chose auquel je réfléchis, mais pour cette PR on peut laisser comme ça.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.