Pilem bonds restart #25
Conversation
btravouillon
left a comment
btravouillon
left a comment
There was a problem hiding this comment.
So sorry I missed this one when we were working together @pilem. 😕
tasks/main.yml
Outdated
| item['configure'] and | ||
| config_interface['changed'] | ||
|
|
||
| - name: Restarting Network Bonds |
There was a problem hiding this comment.
Should this restart before the bridges?
I guess there is a highest chance that a bridge requires a bond to exist than the opposite.
There was a problem hiding this comment.
Yes, good catch. I'll swap the restart order.
tasks/main.yml
Outdated
| when: (ifupdown_network_interfaces | length > 0 or ifupdown_network_vlans | length > 0 or | ||
| ifupdown_network_bridges | length > 0 or ifupdown_network_bonds | length > 0 or | ||
| ifupdown_ovs_bridges | length > 0 or ifupdown_ovs_bonds | length > 0 or | ||
| ifupdown_ovs_interfaces | length > 0 or ifupdown_ovs_ports | length > 0) |
There was a problem hiding this comment.
I wonder if this when clause makes sense. I would remove it and execute this task at each run.
I mean, I can't see no obvious reason to use this role if not to configure /etc/network/interfaces. 🤔
There was a problem hiding this comment.
That makes sense. I'll remove this condition.
| dns-search {{ ifupdown_dns_search }} | ||
| {% endif %} | ||
|
|
||
| source /etc/network/interfaces.d/* |
There was a problem hiding this comment.
Could you please make it a condition to not change the default behaviour?
| source /etc/network/interfaces.d/* | |
| {% if ifupdown_source_interfaces_d | bool %} | |
| source /etc/network/interfaces.d/* | |
| {% endif %} |
- add this to
defaults/main.yml:
ifupdown_source_interfaces_d: false
…art, made sourcing interfaces.d content optional
btravouillon
left a comment
btravouillon
left a comment
There was a problem hiding this comment.
Looks good to me. 👍
ping @pbouchez 😺
|
fwiw 2 workflows are awaiting approval from a maintainer (which I'm not anymore 😢) |
I ran them and the checks are now failing :( |
|
And #27 for molecule tests. |
|
@pilem : Do you have a working GPG key associated to your GitHub account? |
6 participants
Restarting Network Bonds added
Conditions to configure defined interfaces added
source /etc/network/interfaces.d/* added