-
Notifications
You must be signed in to change notification settings - Fork 3
Add a folder and a separated Dockerfile for the frontend tests #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
soline-b
wants to merge
8
commits into
master
Choose a base branch
from
unit-tests-javascript
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6838c34
Add a folder and a separated Dockerfile for the frontend tests
soline-b c0b5403
Fix path error in CI
soline-b 46450cb
Update file permission in the Docker
soline-b 3cb9ee2
Update file permission in the Docker
soline-b ada7282
Update file permission in the Docker
soline-b 88c408e
Remove specific CI for frontend
soline-b 932c999
Update file permission in the Docker
soline-b 210c23e
Update file permission in the Docker
soline-b File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
FROM clockwork_web | ||
|
||
# Create folder required by Playwright to install browsers | ||
# and set permissions so that Playwright can install browsers in this folder | ||
RUN mkdir /.cache | ||
RUN chmod -R 777 /.cache | ||
|
||
RUN apt update && apt install -y build-essential | ||
|
||
# Install OS packages required for Playwright browsers | ||
# https://github.com/microsoft/playwright-python/issues/498#issuecomment-856349356 | ||
RUN apt install -y gstreamer1.0-libav libnss3-tools libatk-bridge2.0-0 libcups2-dev libxkbcommon-x11-0 libxcomposite-dev libxrandr2 libgbm-dev libgtk-3-0 | ||
|
||
# Install Python requirements for clockwork frontend/javascript tests. | ||
# This include package `pytest-playwright`. | ||
COPY clockwork_frontend_test/requirements.txt /requirements_frontend_test.txt | ||
RUN pip install -r /requirements_frontend_test.txt && rm -rf /root/.cache | ||
|
||
# Add a variable available only inside container. | ||
ENV WE_ARE_IN_DOCKER=1 | ||
ENV CLOCKWORK_ENABLE_TESTING_LOGIN="True" | ||
|
||
CMD ["bash", "clockwork_frontend_test/launch_frontend_tests_in_clockwork_dev.sh"] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really happy with this, but could not find another option for now.