Skip to content

Conversation

@lebrice
Copy link
Collaborator

@lebrice lebrice commented Dec 18, 2024

No description provided.

@lebrice lebrice requested a review from Copilot December 18, 2024 14:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Getting inconsistent errors in CI, maybe due to a codecov issue?
- Example: https://github.com/mila-iqia/milatools/actions/runs/12419445408/job/34676165915?pr=137
- Issue on the CodeCov action repo: codecov/codecov-action#1580

Signed-off-by: Fabrice Normandin <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.33%. Comparing base (e413b54) to head (32f867b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
+ Coverage   74.00%   74.33%   +0.33%     
==========================================
  Files          17       17              
  Lines        2312     2307       -5     
==========================================
+ Hits         1711     1715       +4     
+ Misses        601      592       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lebrice lebrice merged commit 63cc24f into mila-iqia:master Dec 20, 2024
23 checks passed
@lebrice lebrice deleted the switch-to-uv branch December 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants