Skip to content

Rework of mila init following changes #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Mar 17, 2025

Rework of mila init following changes to the procedure to get SSH access to the Mila cluster.

TODOs:

  • Rework mila init, display the form and public key, etc.
  • Adapt the tests

Signed-off-by: Fabrice Normandin [email protected]

lebrice added 6 commits March 17, 2025 15:48
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
Signed-off-by: Fabrice Normandin <[email protected]>
@lebrice lebrice marked this pull request as ready for review March 28, 2025 19:01
@lebrice lebrice requested review from obilaniu and breuleux March 28, 2025 19:09
@lebrice lebrice changed the title WIP: Rework of mila init following changes Rework of mila init following changes Mar 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 26.52174% with 169 lines in your changes missing coverage. Please review.

Project coverage is 70.97%. Comparing base (5a976a2) to head (6616c7a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
milatools/cli/init_command.py 25.66% 168 Missing ⚠️
milatools/cli/utils.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   74.42%   70.97%   -3.45%     
==========================================
  Files          17       17              
  Lines        2307     2388      +81     
==========================================
- Hits         1717     1695      -22     
- Misses        590      693     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants