Fix flag search #122
Merged
Fix flag search #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a bit more standard wording
breuleux
reviewed
Jan 21, 2026
tests/collection/test_collections.py
Outdated
| # Test include_flags: papers must have ALL specified flags | ||
| results = sorted(collection.search(include_flags=["valid"]), key=lambda x: x.title) | ||
| assert len(results) == 3 | ||
| check_papers(data_regression, results, basename=f"{tmp_path.name}_0") |
Member
There was a problem hiding this comment.
Instead of a regression, could we simply check that all results have/don't have the specified flags? We could also regress on the paper titles only.
breuleux
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify flag filtering API
Refactor flag-based search to use a unified
flagsparameter with~prefix for exclusions, replacing separateinclude_flags/exclude_flagsparameters and the deprecatedvalidatedparameter.Changes
include_flags/exclude_flagswith singleflagsparameter (exclusions prefixed with~)~prefix from exclude_flags in CLI before passing to searchvalidatedparameter toflagsformat (valid/invalid/~valid,~invalid)