Merge Paper and PaperInfo #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breuleux
force-pushed
the
merge-info
branch
2 times, most recently
from
3b02b55 to
fdccec2
Compare
satyaog
approved these changes
Jan 27, 2026
Member
satyaog
left a comment
satyaog
left a comment
There was a problem hiding this comment.
I mostly feel we could want to keep the key field in the file regressions
tests/conftest.py
Outdated
| Paper: {"id", "version"}, | ||
| PaperInfo: {"acquired"}, | ||
| } | ||
| omissions = {Paper: {"id", "version", "key", "info", "score"}} |
Member
There was a problem hiding this comment.
Wouldn't we want to keep key (and maybe info) in the file regression? Just to make sure we do have something in there as we're using key to filter some papers in the code?
Member
Author
There was a problem hiding this comment.
I think I omitted them to minimize regression disruption, because extra fields would pop into regression tests for Paper. But I think you're right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information collected in PaperInfo can be useful in the collection database, so both data structures are merged. This also simplifies the code a little by removing some indirections.