Add Finder, timeouts #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
breuleux
commented
Sep 24, 2025
breuleux
commented
- Refactor some of the paper finding logic into a Finder class
- Add a timeout to all requests
satyaog
reviewed
Sep 25, 2025
| if mem_col.find_paper(pinfo.paper): | ||
|
|
||
| if found := find.find(pinfo.paper): | ||
| found.value.add(pinfo) |
There was a problem hiding this comment.
Is scored automatically updated here or is there another operation that needs to be done? Something like the following?
Suggested change
| found.value.add(pinfo) | |
| found.value.add(pinfo) | |
| found.score = work.focuses.score(found.value.current) |
satyaog
reviewed
Oct 1, 2025
Comment on lines
+35
to
+41
| sim = quick_author_similarity(au1, au2) | ||
| if sim >= 0.8: | ||
| return same_title | ||
| else: | ||
| logging.warning( | ||
| f"Title match but low author similarity ({sim:.2f}) for paper '{p.title}': {au1} vs {au2}" | ||
| ) |
There was a problem hiding this comment.
in which case do we have a matching title but wouldn't want to return a paper?
Merged
|
Closing as superseded by #95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.