Open
Conversation
Multiple statically selected DNS servers should be configured for dhcpcd as a one-line "--static domain_name_servers" command line option, with space-separated DNS server IP addresses. Putting DNS servers individually is not correct, dhcpcd will only use the last entry. Additionally, since output from dhcpcd is used to feed resolv.conf (even with static IP config), it makes sense to put to same data into DeviceNetworkStatus, as opposed to just copying DNS servers from DPC, otherwise it can be confusing during debugging. Signed-off-by: Milan Lenco <milan@zededa.com>
In situations where customers use override.json, we can sometimes see that going from override to zedagent DPC may trigger unecessary restarts of dhcpcd instances, resulting in interfaces giving up on their existing IP addresses and immediately asking for new ones. This can for example break an ongoing download process. These restarts are unecessary in the sense that arguments of restarted dhcpcd instances might have not actually changed. This can be prevented by improving the Equal method for DHCP config, considering two configs as equivalent if their effect is the same (i.e. same dhcpcd args). Signed-off-by: Milan Lenco <milan@zededa.com>
milan-zededa
force-pushed
the
dhcp-config-comparison
branch
from
43ab55c to
4257781
Compare
milan-zededa
pushed a commit
that referenced
this pull request
May 22, 2023
initialize LinuxDpcReconciler KubeClusterMode in nim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In situations where customers use override.json, we can sometimes see that going from override to zedagent DPC may trigger unecessary restarts of dhcpcd instances, resulting in interfaces giving up on their existing IP addresses and immediately asking for new ones. This can for example break an ongoing download process.
These restarts are unecessary in the sense that arguments of restarted dhcpcd instances might have not actually changed. This can be prevented by improving the Equal method for DHCP config, considering two configs as equivalent if their effect is the same (i.e. same dhcpcd args).
Signed-off-by: Milan Lenco milan@zededa.com