Fix #347: Preserve HTML entities like © during processing#425
Merged
martinnormark merged 2 commits intoMay 21, 2025
Conversation
Co-Authored-By: m@martinnormark.com <m@martinnormark.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: m@martinnormark.com <m@martinnormark.com>
martinnormark
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HTML Entities Conversion Issue (#347)
Problem
When processing HTML text containing HTML entities, such as
©, PreMailer.Net converts them to the corresponding characters (such as©). This causes display issues in Gmail, which shows a notice that the message was trimmed when it encounters the©character, but displays correctly when using the©entity.Root Cause
AngleSharp's HTML parser converts HTML entities to characters during parsing, and the default
HtmlMarkupFormatteronly re-encodes specific characters (&,<,>,", etc.) during serialization. For other special characters like the copyright symbol (©), it doesn't convert them back to their entity form.Solution
PreserveEntitiesHtmlMarkupFormatterthat extends AngleSharp'sHtmlMarkupFormatterto convert special characters back to their HTML entity equivalents during serialization.preserveEntitiesparameter to allMoveCssInlinemethod overloads to control whether HTML entities should be preserved.preserveEntitiesis set totrue, the custom formatter is used instead of the default one.Testing
MoveCssInlinemethod to verify that thepreserveEntitiesparameter works correctly.Usage
Link to Devin run
Requested by: m@martinnormark.com