chore: switch from npm to pnpm as package manager by devin-ai-integration[bot] · Pull Request #520 · millicast/millicast-sdk

devin-ai-integration · 2026-05-28T02:24:00Z

Summary

Migrates the millicast-sdk monorepo from npm + Lerna to pnpm workspaces, following the same patterns used across 18 other millicast/CoSMoSoftware repositories.

Changes:

Package manager: Replaced package-lock.json with pnpm-lock.yaml (imported via pnpm import)
pnpm-workspace.yaml: Created with standard config (trustPolicy: no-downgrade, engineStrict: true, minimumReleaseAge: 10080, allowBuilds for native packages)
package.json:
- Set packageManager to pnpm@11.1.2 with SHA matching all other repos
- Added engines.node: ">=24.0.0" and engines.pnpm: ">=11.0.0"
- Replaced all lerna run scripts with pnpm -r run / pnpm --filter equivalents
- Removed lerna, @lerna/publish, install, npm from devDependencies
lerna.json: Removed (no longer needed with pnpm workspaces)
CI workflows (check-tests.yml, new-release.yml, rc-release.yml): Updated to use actions/setup-node with Node 24, corepack enable, and pnpm ci
- Added PUPPETEER_SKIP_DOWNLOAD=true for unit-test/e2e-test jobs + explicit npx puppeteer browsers install chrome step (pnpm's strict node_modules causes puppeteer's postinstall to create a corrupt cache)
jsdoc.json: Fixed plugin/template paths from ../../node_modules/ to node_modules/ (pnpm doesn't hoist to root)
Sub-package scripts: npm run → pnpm run in packages/millicast-sdk/package.json
CONTRIBUTING.md: Updated all instructions from npm/Lerna to pnpm

CI Status:

✅ eslint — passes
✅ unit-test — passes (173/173 tests)
✅ build-docs — passes
✅ e2e-test — passes (needed to reactivate account used with publish token)
⏳ Analyze (javascript) / Devin Review — passes

Review & Testing Checklist for Human

Verify pnpm publish commands in new-release.yml and rc-release.yml work correctly with --no-git-checks flag
Confirm the e2e-test account credentials (PUBLISHER_DEMO_ACC_ID / PUBLISHER_DEMO_TOKEN) are still valid — all 4 e2e failures are Unauthorized: Account disabled
Test a local dev workflow: clone, corepack enable, pnpm ci, pnpm run build, pnpm run start

Notes

The codeql-analysis.yml workflow was not modified since it uses GitHub's autobuild action which auto-detects the build system
The husky v4 pre-commit hook has a known issue with pnpm (npx → pnpm dlx translation fails). Upgrading to husky v9+ would resolve it but is out of scope for this migration
nx.json was kept since it doesn't depend on lerna and may be useful for build caching

Link to Devin session: https://dolby.devinenterprise.com/sessions/9b9e1c01e1b3454a96e298bf03675273
Requested by: @nicholi

- Replace npm with pnpm as the package manager - Convert package-lock.json to pnpm-lock.yaml via pnpm import - Add pnpm-workspace.yaml with trustPolicy, engineStrict, minimumReleaseAge - Set packageManager to pnpm@11.1.2 with SHA - Add engines.node >=24.0.0 and engines.pnpm >=11.0.0 - Replace lerna scripts with pnpm workspace equivalents - Remove lerna, @lerna/publish, install, npm devDependencies - Remove lerna.json - Update all CI workflows to use pnpm ci + Node 24 - Update sub-package scripts from npm run to pnpm run - Update CONTRIBUTING.md for pnpm usage

devin-ai-integration · 2026-05-28T02:24:03Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

changeset-bot · 2026-05-28T02:24:04Z

⚠️ No Changeset found

Latest commit: fdb7a98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

The relative paths ../../node_modules/ assumed npm's hoisted flat structure. With pnpm, these packages are in the local package's node_modules/ directory. Co-Authored-By: nicholi <nicholas.schell@dolby.com>

pnpm's strict node_modules prevents puppeteer's postinstall from being found by jest-environment-puppeteer. Add an explicit install step to ensure Chrome is available for unit and e2e tests. Co-Authored-By: nicholi <nicholas.schell@dolby.com>

Puppeteer's postinstall creates the cache folder but fails to extract the Chrome binary on CI. Skip the automatic download during pnpm ci and use the explicit puppeteer browsers install step instead. Co-Authored-By: nicholi <nicholas.schell@dolby.com>

pnpm --filter exec doesn't properly run the puppeteer CLI. Use npx with working-directory set to the millicast-sdk package instead. Co-Authored-By: nicholi <nicholas.schell@dolby.com>

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

…ch-to-pnpm

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

and also dryrun workflow targeted at millicast-sdk

publishing to npmjs with trusted publisher

allow being called manually through workflow_dispatch

always specify shell: bash (because we are using ubuntu container here) some cosmetic whitespace between steps use pnpm exec for eslint

always specify shell: bash (because we are using ubuntu container here) some cosmetic whitespace between steps

add node-gyp devDependency for millicast-sdk

copy README for publish too

we can enforce signatures in github repo

should quickly update these to versions with provenance in newer packages

nicholi · 2026-05-28T14:07:04Z

TODO

how to incorporate changesets into node-release.yml more appropriately. How does version bumping work with changesets? Play with tools some.

Probably understand this fully and merge first.
#513

add environment section to job drop new-release (now everything moved to node-release)

devin-ai-integration Bot assigned nicholi May 28, 2026

devin-ai-integration Bot and others added 4 commits May 28, 2026 02:25

fix: update jsdoc plugin paths for pnpm node_modules structure

0ff25b7

The relative paths ../../node_modules/ assumed npm's hoisted flat structure. With pnpm, these packages are in the local package's node_modules/ directory. Co-Authored-By: nicholi <nicholas.schell@dolby.com>

fix: use npx for puppeteer browser install in CI

619896d

pnpm --filter exec doesn't properly run the puppeteer CLI. Use npx with working-directory set to the millicast-sdk package instead. Co-Authored-By: nicholi <nicholas.schell@dolby.com>

This comment was marked as resolved.

Sign in to view

nicholi requested changes May 28, 2026

View reviewed changes

Comment thread pnpm-workspace.yaml

chore: reorder pnpm-workspace.yaml - move policy directives to top

eaa7a45

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

This comment was marked as resolved.

Sign in to view

devin-ai-integration Bot and others added 3 commits May 28, 2026 10:03

Merge remote-tracking branch 'origin/main' into devin/1779934552-swit…

2c55ec5

…ch-to-pnpm

chore: update start:projects script after publisher-demo removal

e28d4b6

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

fix: use pnpm exec for puppeteer browser install in CI

0ee6b2e

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

This comment was marked as resolved.

Sign in to view

devin-ai-integration Bot and others added 14 commits May 28, 2026 10:13

fix: add puppeteer download workaround to new-release.yml

284a146

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

chore: remove unused nx.json - nx was never installed

c80f8fc

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

fix: use node install.mjs for reliable puppeteer browser install in CI

f18745c

Co-Authored-By: nicholi <nicholas.schell@dolby.com>

remove packages for removed apps

0c4087c

drop old package-lock files

b1bbf9b

drop next workflow stuff

0c3e22a

add composite build action

7fbf17b

and also dryrun workflow targeted at millicast-sdk

skip new-release work for next as well

e0ab82c

add node-release and pnpm-build-publish workflows

203aa7d

publishing to npmjs with trusted publisher

bump to recent workflow versions

b261e22

allow being called manually through workflow_dispatch

bump to recent workflow versions

19a3b52

always specify shell: bash (because we are using ubuntu container here) some cosmetic whitespace between steps use pnpm exec for eslint

bump to recent workflow versions

8749a36

always specify shell: bash (because we are using ubuntu container here) some cosmetic whitespace between steps

consistent always use ./ for packages path

9c6d9ef

consistent always use ./ for packages path

4637003

add node-gyp devDependency for millicast-sdk

This comment was marked as resolved.

Sign in to view

nicholi added 2 commits May 28, 2026 05:47

install chromium manually

bba403b

need sudo

86bfbcb

This comment was marked as resolved.

Sign in to view

nicholi added 2 commits May 28, 2026 06:02

set PUPPETEER_EXECUTABLE_PATH

5808400

same steps for e2e-test

84504e3

This comment was marked as resolved.

Sign in to view

nicholi added 2 commits May 28, 2026 06:24

check-tests can be used in place of dryrun here

7852fe1

move composite action pnpn-build directly into pnpm-build-publish

dcf942d

This comment was marked as resolved.

Sign in to view

nicholi added 5 commits May 28, 2026 06:39

just hardcode pnpm-build-publish to work with millicast-sdk

a4f7f32

copy README for publish too

copy README and changedirs first

4877871

un-necessary external script

87fdbe1

we can enforce signatures in github repo

skip tests in new-release

d15eee7

add problematic packages to trustPolicyExclude

5400c9f

should quickly update these to versions with provenance in newer packages

This comment was marked as resolved.

Sign in to view

drop husky, lint-staged, and git hooks

b7ece2d

This comment was marked as resolved.

Sign in to view

add deploying github pages during node-release

f625500

This comment was marked as resolved.

Sign in to view

nicholi added 2 commits May 28, 2026 08:00

add deploying github pages during node-release

a88266a

add environment section to job drop new-release (now everything moved to node-release)

millicast-sdk used next dist-tag historically

bc4e1f0

This comment was marked as resolved.

Sign in to view

nicholi added 3 commits May 28, 2026 08:16

required to use --no-git-checks because we copy the README

6926f05

there are no scripts

d229688

both fully moved out of repo

65c351a

This comment was marked as resolved.

Sign in to view

run tests on every commit and every tag, doesn't matter what branch

fdb7a98

This comment was marked as resolved.

Sign in to view

Conversation

devin-ai-integration Bot commented May 28, 2026 • edited by nicholi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes:

CI Status:

Review & Testing Checklist for Human

Notes

Uh oh!

devin-ai-integration Bot commented May 28, 2026

🤖 Devin AI Engineer

Uh oh!

changeset-bot Bot commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

nicholi commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

devin-ai-integration Bot commented May 28, 2026 •

edited by nicholi

Loading

changeset-bot Bot commented May 28, 2026 •

edited

Loading

nicholi commented May 28, 2026 •

edited

Loading