Skip to content

fix(website): keep diagnostic count next to rule name on narrow widths #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidenybai merged 1 commit into from
May 9, 2026
Merged

fix(website): keep diagnostic count next to rule name on narrow widths #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions packages/website/src/components/terminal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ const TOTAL_ISSUE_COUNT = 36;
const TOTAL_SOURCE_FILE_COUNT = 42;
const AFFECTED_FILE_COUNT = 18;
const ELAPSED_TIME = "2.1s";
const RULE_NAME_COLUMN_WIDTH = 42;

const ANIMATION_COMPLETED_KEY = "react-doctor-animation-completed";
const COMMAND = "npx react-doctor@latest";
Expand Down Expand Up @@ -96,11 +95,6 @@ const FadeIn = ({ children }: { children: React.ReactNode }) => (
<div className="animate-fade-in">{children}</div>
);

const padRuleName = (ruleName: string): string => {
if (ruleName.length >= RULE_NAME_COLUMN_WIDTH) return ruleName;
return ruleName + "\u00A0".repeat(RULE_NAME_COLUMN_WIDTH - ruleName.length);
};

const ScoreBar = ({ score, barWidth }: { score: number; barWidth: number }) => {
const filledCount = Math.round((score / PERFECT_SCORE) * barWidth);
const emptyCount = barWidth - filledCount;
Expand Down Expand Up @@ -168,10 +162,8 @@ const DiagnosticItem = ({ diagnostic }: { diagnostic: RuleDiagnostic }) => {
/>
<span>
<span className={colorClass}>{icon} </span>
<span className={colorClass}>
{countBadge ? padRuleName(diagnostic.ruleKey) : diagnostic.ruleKey}
</span>
{countBadge && <span className="text-neutral-500">{` ${countBadge}`}</span>}
<span className={colorClass}>{diagnostic.ruleKey}</span>
{countBadge && <span className="text-neutral-500">{`\u00A0${countBadge}`}</span>}
</span>
</button>
<div
Expand Down
Loading