Skip to content

fix: skip response.headers.set() in GET handler side-effect check (#206) #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PranavAgarkar07 wants to merge 1 commit into from
Closed

fix: skip response.headers.set() in GET handler side-effect check (#206) #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/react-doctor/src/plugin/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,6 +361,16 @@ const isMutatingFetchCall = (node: EsTreeNode): boolean => {
return Boolean(optionsArgument.properties?.some(isMutatingMethodProperty));
};

const isHeadersChainCall = (node: EsTreeNode): boolean => {
if (node.type !== "CallExpression" || node.callee?.type !== "MemberExpression") return false;
let cursor: EsTreeNode | undefined = node.callee.object;
while (cursor?.type === "MemberExpression") {
if (cursor.property?.type === "Identifier" && cursor.property.name === "headers") return true;
cursor = cursor.object;
}
return false;
};

export const findSideEffect = (node: EsTreeNode): string | null => {
let sideEffectDescription: string | null = null;
walkAst(node, (child: EsTreeNode) => {
Expand All @@ -378,7 +388,7 @@ export const findSideEffect = (node: EsTreeNode): string | null => {
// would).
const methodProperty = child.arguments[1].properties.find(isMutatingMethodProperty);
sideEffectDescription = `fetch() with method ${methodProperty.value.value}`;
} else if (isMutatingDbCall(child)) {
} else if (isMutatingDbCall(child) && !isHeadersChainCall(child)) {
const methodName = child.callee.property.name;
const objectName =
child.callee.object?.type === "Identifier" ? child.callee.object.name : null;
Expand Down