Skip to content

Fix build and pack as .NET tool - #2

Open
josesimoes wants to merge 1 commit into
miloush:net60from
josesimoes:fix-build
Open

Fix build and pack as .NET tool#2
josesimoes wants to merge 1 commit into
miloush:net60from
josesimoes:fix-build

Conversation

@josesimoes

@josesimoes josesimoes commented Feb 24, 2023

Copy link
Copy Markdown
  • Adjust target frameworks.
  • Migrate current projects to 4.7.2, add also to target framework in projects referencing these.
  • Rework referencing projects to get proper referencing.
  • Fix output type of TFConvert to output executable.
  • Add hack to allow package as .NET tool despite being able to run only on windows.
  • Add check for running on Windows platform.
  • Move properties to package as tool to main project.
  • Assembly name, package id and tool command name are now all lower case and the same for consistency.

- Adjust target frameworks.
- Migrate current projects to 4.7.2, add also to target framework in projects referencing these.
- Rework referencing projects to get proper referencing.
- Fix output type of TFConvert to output executable.
- Add hack to allow package as .NET tool despite being able to run only on windows.
- Add check for running on Windows platform.
- Move properties to package as tool to main project.
- Assembly name, package id and tool command name are now all lower case and the same for consistency.
@miloush

miloush commented Feb 26, 2023

Copy link
Copy Markdown
Owner

This gives me

The settings file in the tool's NuGet package is invalid: Entry point file 'tfconvert.dll' for command 'tfconvert' was not found in the package.
Tool 'tfconvert' failed to install. Contact the tool author for assistance.

Can you comment on commenting out some of the tests?

@josesimoes

Copy link
Copy Markdown
Author

Yes, I can see the same here when trying to install... will try some workarounds in the coming days
As for the testing I comment out those who weren't possible to run because of the change to the new target framework. Most likely they just need some tweak or minor rework. Didn't spent much time on it.

@josesimoes

Copy link
Copy Markdown
Author

This is defenitly not working at all!

I'm thinking that another approach could be to have the CLI build as a .NET tool, but instead of TFConvert being the tool it would be instead a wrapper that would call the "original" TFConvert CLI that can be build as usual (just that updated to the latest .NET Framework version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants