enhance: update snapshot design for collection lifecycle binding#25
Open
weiliu1031 wants to merge 2 commits intomilvus-io:mainfrom
Open
enhance: update snapshot design for collection lifecycle binding#25weiliu1031 wants to merge 2 commits intomilvus-io:mainfrom
weiliu1031 wants to merge 2 commits intomilvus-io:mainfrom
Conversation
Update the snapshot design document to reflect the per-collection snapshot lifecycle binding changes implemented in milvus-io/milvus PR #48143. Key additions: - Snapshot Lifecycle Management section: design motivation, per-collection name scoping, cascade delete on drop collection, RBAC privilege model - Two-layer fault tolerance: synchronous cascade delete + async GC fallback - DropSnapshotsByCollection WAL message type and implementation details - Known limitations documentation Key modifications: - SnapshotManager interface: all methods now require collectionID parameter - DropSnapshotsByCollection added to SnapshotMeta core functions - Orphan snapshot GC detection in garbage collection section - Snapshot lifecycle flowchart: separate single drop vs cascade drop - Restore Phase 1: source-target collection separation with propagation chain - API Reference: unified per-collection scoping changes table, restructured RestoreSnapshot API with source/target distinction Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
7 tasks
Add comprehensive design documentation for the dual-layer compaction protection mechanism that prevents snapshot-referenced segments from being compacted during a user-specified protection window. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the snapshot design document to reflect the per-collection snapshot lifecycle binding changes implemented in #48143.
Key Additions
Key Modifications
collectionIDparameter for per-collection name scopingRestoreSnapshotAPI with explicit source/target distinctionsource_collection_idfield for restore operationsTest plan
data_coord.protoandmessages.proto🤖 Generated with Claude Code