Update README to add information about generating proto files after making changes#412
Open
gifi-siby wants to merge 1 commit intomilvus-io:masterfrom
Open
Update README to add information about generating proto files after making changes#412gifi-siby wants to merge 1 commit intomilvus-io:masterfrom
gifi-siby wants to merge 1 commit intomilvus-io:masterfrom
Conversation
…changes Signed-off-by: “gifi-siby” <“gifi.s@ibm.com“>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gifi-siby The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @gifi-siby! It looks like this is your first PR to milvus-io/milvus-proto 🎉 |
|
@gifi-siby Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”) |
mergify
bot
added
do-not-merge/missing-related-issue
and removed
do-not-merge/missing-related-issue
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current README file, there is no information about generating the proto files after making changes. Milvus will take up our changes only if we generate proto files with the changes made.
Related task: #413