feat: Add PrivilegeExpr for /expr endpoint RBAC

[shaoting-huang]

related: milvus-io/milvus#46442
Add PrivilegeExpr privilege (ID=85) to support RBAC authorization for the /expr HTTP endpoint in Milvus.

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign nameczz after the PR has been reviewed.
You can assign the PR to them by writing /assign @nameczz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @shaoting-huang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances Milvus's security model by integrating a new privilege into its Role-Based Access Control system. The addition of PrivilegeExpr specifically targets the /expr HTTP endpoint, allowing administrators to define and enforce granular access policies for this functionality. This change involves updating the core protocol buffer definitions to support the new privilege.

Highlights

• New Privilege Definition: Introduced PrivilegeExpr with ID 85 into the ObjectPrivilege enum, expanding the available authorization options.
• RBAC for /expr Endpoint: This new privilege enables Role-Based Access Control (RBAC) specifically for the /expr HTTP endpoint in Milvus, allowing for more granular access control.
• Protocol Buffer Updates: Modified proto/common.proto and its generated Go counterpart go-api/commonpb/common.pb.go to incorporate the new privilege definition.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully introduces the PrivilegeExpr enum value (ID=85) to support RBAC authorization for the /expr HTTP endpoint. The changes are consistent across the proto/common.proto definition and its generated go-api/commonpb/common.pb.go file. The addition is straightforward and aligns with the stated objective of extending RBAC capabilities. No issues were found that require specific comments.