Skip to content
This repository was archived by the owner on Mar 21, 2025. It is now read-only.

Conversation

@congqixia
Copy link
Contributor

See also #637

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from sunby and yah01 December 8, 2023 07:44
@sre-ci-robot sre-ci-robot added approved review approved size/XL Denotes a PR that changes 500-999 lines. labels Dec 8, 2023
@codecov
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: Patch coverage is 88.88889% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 73.95%. Comparing base (43226a3) to head (d7e7849).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   74.95%   73.95%   -1.00%     
==========================================
  Files          44       44              
  Lines        4125     4293     +168     
==========================================
+ Hits         3092     3175      +83     
- Misses        921      990      +69     
- Partials      112      128      +16     
Files Coverage Δ
client/alias.go 100.00% <100.00%> (ø)
client/authentication.go 100.00% <100.00%> (ø)
client/config.go 74.19% <100.00%> (+2.76%) ⬆️
client/mq_message.go 90.90% <100.00%> (-9.10%) ⬇️
client/rbac.go 100.00% <100.00%> (ø)
client/resource_group.go 100.00% <100.00%> (ø)
client/row.go 85.77% <100.00%> (-0.65%) ⬇️
client/client.go 37.20% <83.33%> (+8.26%) ⬆️
client/maintainance.go 87.75% <92.85%> (-7.60%) ⬇️
client/partition.go 86.88% <96.96%> (+2.81%) ⬆️
... and 7 more

@congqixia congqixia force-pushed the support_conn_poolling branch from 3ef070c to 4b633af Compare December 8, 2023 07:54
@congqixia congqixia force-pushed the support_conn_poolling branch from 4b633af to d7e7849 Compare December 8, 2023 08:38
@mergify mergify bot added the ci-passed auto merge needed label label Dec 8, 2023
@congqixia
Copy link
Contributor Author

/kind feature

@sre-ci-robot sre-ci-robot added the kind/feature Issues related to feature request from users label Dec 8, 2023
@congqixia
Copy link
Contributor Author

/hold

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved review approved ci-passed auto merge needed label do-not-merge/hold kind/feature Issues related to feature request from users size/XL Denotes a PR that changes 500-999 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants