Skip to content

Redact credentials from connection configuration logs - #1994

Merged
sre-ci-robot merged 1 commit into
milvus-io:3.0from
yhmo:30
Aug 5, 2026
Merged

Redact credentials from connection configuration logs#1994
sre-ci-robot merged 1 commit into
milvus-io:3.0from
yhmo:30

Conversation

@yhmo

@yhmo yhmo commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify

mergify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@yhmo yhmo added the lgtm label Aug 5, 2026
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (3.0@9ef6b0e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../io/milvus/v2/client/globalcluster/GlobalStub.java 0.00% 5 Missing ⚠️
.../main/java/io/milvus/v2/client/MilvusClientV2.java 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##             3.0    #1994   +/-   ##
======================================
  Coverage       ?   65.07%           
  Complexity     ?     4261           
======================================
  Files          ?      473           
  Lines          ?    26442           
  Branches       ?     2510           
======================================
  Hits           ?    17207           
  Misses         ?     7875           
  Partials       ?     1360           
Files with missing lines Coverage Δ
.../java/io/milvus/common/utils/RedactCredential.java 100.00% <100.00%> (ø)
...re/src/main/java/io/milvus/param/ConnectParam.java 64.43% <100.00%> (ø)
...milvus/param/credential/CreateCredentialParam.java 72.72% <100.00%> (ø)
...milvus/param/credential/UpdateCredentialParam.java 73.33% <100.00%> (ø)
...c/main/java/io/milvus/v2/client/ConnectConfig.java 66.66% <100.00%> (ø)
...vus/v2/client/globalcluster/TopologyRefresher.java 53.48% <100.00%> (ø)
...o/milvus/v2/service/cdc/request/MilvusCluster.java 63.26% <100.00%> (ø)
.../milvus/v2/service/rbac/request/CreateUserReq.java 77.77% <100.00%> (ø)
...vus/v2/service/rbac/request/UpdatePasswordReq.java 75.60% <100.00%> (ø)
.../main/java/io/milvus/v2/client/MilvusClientV2.java 53.20% <0.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify Bot added the ci-passed label Aug 5, 2026
@sre-ci-robot
sre-ci-robot merged commit 035dd3e into milvus-io:3.0 Aug 5, 2026
7 of 8 checks passed
@yhmo
yhmo deleted the 30 branch August 5, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants