Skip to content

Support description updates#580

Open
shanghaikid wants to merge 1 commit into
mainfrom
feat/description-updates
Open

Support description updates#580
shanghaikid wants to merge 1 commit into
mainfrom
feat/description-updates

Conversation

@shanghaikid

Copy link
Copy Markdown
Contributor

Summary

  • update proto submodule and regenerate proto JSON
  • support user and role descriptions in gRPC SDK APIs
  • add integration coverage for collection, field, user, and role description updates

Tests

  • npm run proto:json
  • env NODE_ENV=dev ./node_modules/.bin/jest test/grpc/Collection.spec.ts --runInBand
  • env NODE_ENV=dev ./node_modules/.bin/jest test/grpc/User.spec.ts --runInBand
  • env NODE_ENV=dev ./node_modules/.bin/jest test/grpc/User.spec.ts test/grpc/Collection.spec.ts --runInBand --coverage --collectCoverageFrom=milvus/grpc/User.ts
  • npm run build

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants