Skip to content

fix(collection): wait for flush completion instead of returning immediately#104

Open
marlon-costa-dc wants to merge 1 commit intomilvus-io:mainfrom
marlon-costa-dc:fix/flush-wait-completion
Open

fix(collection): wait for flush completion instead of returning immediately#104
marlon-costa-dc wants to merge 1 commit intomilvus-io:mainfrom
marlon-costa-dc:fix/flush-wait-completion

Conversation

@marlon-costa-dc
Copy link

Summary

  • The flush method previously returned immediately after sending the request.
  • This PR updates it to poll GetFlushState and wait for the flush to actually complete (up to 30s timeout).
  • This prevents race conditions where subsequent operations fail because the flush hasn't finished.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marlon-costa-dc
To complete the pull request process, please assign yah01 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yah01 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link

mergify bot commented Feb 25, 2026

@marlon-costa-dc Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco label Feb 25, 2026
@mergify
Copy link

mergify bot commented Feb 25, 2026

@marlon-costa-dc Please associate the related issue to the body of your Pull Request. (eg. “issue: #187”)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants