Skip to content

refactor: resolve clippy warnings and apply idiomatic rust patterns#108

Open
marlon-costa-dc wants to merge 1 commit intomilvus-io:mainfrom
marlon-costa-dc:refactor/clippy-and-idiomatic-fixes
Open

refactor: resolve clippy warnings and apply idiomatic rust patterns#108
marlon-costa-dc wants to merge 1 commit intomilvus-io:mainfrom
marlon-costa-dc:refactor/clippy-and-idiomatic-fixes

Conversation

@marlon-costa-dc
Copy link

Summary

  • Resolves various clippy warnings across the codebase.
  • Replaces push_str(",") with push(',').
  • Uses matches!() macro where appropriate.
  • Adds is_empty() method to FieldColumn.
  • Removes redundant manual Default implementations in favor of #[derive(Default)].
  • Simplifies struct initializations (field init shorthand).

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marlon-costa-dc
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link

mergify bot commented Feb 25, 2026

@marlon-costa-dc Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify
Copy link

mergify bot commented Feb 25, 2026

@marlon-costa-dc Please associate the related issue to the body of your Pull Request. (eg. “issue: #187”)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants