Upgrade tonic from 0.11 to 0.13 and prost from 0.12 to 0.13#111
Open
danghoangnhan wants to merge 1 commit intomilvus-io:mainfrom
Open
Upgrade tonic from 0.11 to 0.13 and prost from 0.12 to 0.13#111danghoangnhan wants to merge 1 commit intomilvus-io:mainfrom
danghoangnhan wants to merge 1 commit intomilvus-io:mainfrom
Conversation
Collaborator
|
Welcome @danghoangnhan! It looks like this is your first PR to milvus-io/milvus-sdk-rust 🎉 |
|
@danghoangnhan Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
Author
|
/assign @yah01 |
Bump dependency versions to resolve version conflicts with projects using tonic 0.13+: - tonic: 0.11.0 → 0.13.1 (features: tls-native-roots, prost) - prost: 0.12.6 → >=0.13, <0.14 - base64: 0.21.0 → 0.22.1 - tonic-build: 0.11.0 → 0.13 API migration (all mechanical, no behavioral changes): - from_i32() → try_from() (prost 0.13 removed from_i32) - tonic::codegen::StdError → Box<dyn Error + Send + Sync> - Endpoint::new(dst) → dst.connect() (already an Endpoint) - compile() → compile_protos() (tonic-build 0.13 rename) - Regenerated proto stubs with tonic-build 0.13 + protoc 28.3 Closes milvus-io#110 Signed-off-by: Daniel Du <danghoangnhan.1@gmail.com>
danghoangnhan
force-pushed
the
upgrade/tonic-0.13
branch
from
d0d597d to
f18b5f5
Compare
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danghoangnhan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the gRPC stack to resolve version conflicts with projects using tonic 0.13+.
tonic: 0.11.0 → 0.13.1 (features:tls-native-roots,prost)prost: 0.12.6 → >=0.13, <0.14base64: 0.21.0 → 0.22.1tonic-build: 0.11.0 → 0.13Changes
All changes are mechanical API migrations with no behavioral differences:
ErrorCode::from_i32(x)→Some(v)/NoneErrorCode::try_from(x)→Ok(v)/Err(_)tonic::codegen::StdErrorBox<dyn std::error::Error + Send + Sync>Endpoint::new(dst)?.connect()dst.connect()(already an Endpoint)tonic_build::configure().compile(...)tonic_build::configure().compile_protos(...)features = ["tls", "tls-roots"]features = ["tls-native-roots", "prost"]Proto stubs regenerated with
tonic-build0.13 +protoc28.3.Motivation
Projects depending on
tonic = "0.13.x"cannot use this SDK because tonic 0.11 and 0.13 expose incompatible types (Channel,Interceptor, etc.). This blocks adoption in ecosystems that have already migrated to the newer gRPC stack.Test plan
cargo build— compiles cleanlycargo test— unit tests passcargo clippy— no new warnings introduced (72 pre-existing warnings unchanged)Closes #110
🤖 Generated with Claude Code