enhance: add minio in cpp CI and split the build and test#388
Merged
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
jiaqizho
force-pushed
the
test-new-ci
branch
5 times, most recently
from
b323c99 to
02a2bf6
Compare
jiaqizho
changed the title
jiaqizho
force-pushed
the
test-new-ci
branch
8 times, most recently
from
7fd91d9 to
83c2295
Compare
tedxu
reviewed
Jan 20, 2026
Comment on lines
+114
to
+115
| - name: Install and run minio | ||
| run: | |
Collaborator
There was a problem hiding this comment.
We shoud make this process a script so it can run locally.
jiaqizho
force-pushed
the
test-new-ci
branch
3 times, most recently
from
182a320 to
92fe9b3
Compare
Collaborator
|
/lgtm |
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiaqizho, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new unittest CI step with minio, also split cpp-ci into build and unittest. If code coverage is introduced later, it will also be added to cpp-ci.