-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: ChannelManager double assignment #41837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ChannelManager double assignment #41837
Conversation
@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@XuanYang-cn E2e jenkins job failed, comment |
@XuanYang-cn go-sdk check failed, comment |
@XuanYang-cn cpp-unit-test check failed, comment |
f2fa468
to
f572905
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41837 +/- ##
===========================================
+ Coverage 73.12% 80.45% +7.33%
===========================================
Files 335 1537 +1202
Lines 30727 216698 +185971
===========================================
+ Hits 22468 174353 +151885
- Misses 8259 36056 +27797
- Partials 0 6289 +6289
🚀 New features to boost your workflow:
|
@XuanYang-cn E2e jenkins job failed, comment |
rerun ut |
This pr fixs double assign in channels, recurr of dropped channel, amend extra channel meta, and refresh incorrect state with DN by the following edits: 1. Loose the lock in advanceStandbys to avoid concurrent assignment. 2. Trasfer ToWatch to ToRelease if DN returns ErrChannelRedupulicate. 3. Remove dup channel when recovering See also: #41876 pr: #41837 --------- Signed-off-by: yangxuan <[email protected]>
This pr fixs double assign in channels, recurr of dropped channel, amend extra channel meta, and refresh incorrect state with DN by the following edits: 1. Loose the lock in advanceStandbys to avoid concurrent assignment. 2. Trasfer ToWatch to ToRelease if DN returns ErrChannelRedupulicate. 3. Remove dup channel when recovering Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
Signed-off-by: yangxuan <[email protected]>
7e47ece
to
5854d51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also: #41876