Skip to content

fix: ChannelManager double assignment #41837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

fix: ChannelManager double assignment #41837

merged 4 commits into from
May 23, 2025

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented May 14, 2025 •
edited
Loading

See also: #41876

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 14, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 14, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2025

@XuanYang-cn Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 14, 2025

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@XuanYang-cn XuanYang-cn force-pushed the fix-channel-manager branch from f2fa468 to f572905 Compare May 15, 2025 10:45
@XuanYang-cn XuanYang-cn mentioned this pull request May 15, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.24590% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (83c9527) to head (5854d51).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/channel_store.go 76.00% 5 Missing and 1 partial ⚠️
internal/datanode/channel/channel_manager.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41837       +/-   ##
===========================================
+ Coverage   73.12%   80.45%    +7.33%     
===========================================
  Files         335     1537     +1202     
  Lines       30727   216698   +185971     
===========================================
+ Hits        22468   174353   +151885     
- Misses       8259    36056    +27797     
- Partials        0     6289     +6289
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 73.10% <ø> (-0.02%) ⬇️
Go 81.90% <85.24%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/channel.go 83.75% <100.00%> (ø)
internal/datacoord/channel_manager.go 86.44% <100.00%> (ø)
internal/datanode/channel/channel_manager.go 89.30% <25.00%> (ø)
internal/datacoord/channel_store.go 78.47% <76.00%> (ø)

... and 1199 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 15, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

sre-ci-robot pushed a commit that referenced this pull request May 16, 2025
@XuanYang-cn
fix: ChannelManager double assignment (#41877)
aa01b6a 
This pr fixs double assign in channels, recurr of dropped channel, amend
extra channel meta, and refresh incorrect state with DN by the following
edits:
1. Loose the lock in advanceStandbys to avoid concurrent assignment.
2. Trasfer ToWatch to ToRelease if DN returns ErrChannelRedupulicate.
3. Remove dup channel when recovering
See also: #41876 
pr: #41837

---------

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
fix: ChannelManager double assignment
8093b4d 
This pr fixs double assign in channels, recurr of dropped channel,
amend extra channel meta, and refresh incorrect state with DN by the
following edits:
1. Loose the lock in advanceStandbys to avoid concurrent assignment.
2. Trasfer ToWatch to ToRelease if DN returns ErrChannelRedupulicate.
3. Remove dup channel when recovering

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
fix comment
aa1a6f5 
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
rm not inused method
0eede8b 
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
ok
5854d51 
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn force-pushed the fix-channel-manager branch from 7e47ece to 5854d51 Compare May 23, 2025 02:45
@mergify mergify bot added the ci-passed label May 23, 2025
czs007
czs007 approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 252d49d into milvus-io:master May 23, 2025
19 of 20 checks passed
@XuanYang-cn XuanYang-cn deleted the fix-channel-manager branch May 23, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 approved these changes

@cydrain cydrain Awaiting requested review from cydrain

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XuanYang-cn @sre-ci-robot @czs007