Skip to content

fix:[2.5] analyzer memory leak because function runner not close #41840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented May 14, 2025

relate: #41213
pr:#41839

@aoiasd aoiasd changed the title fix: analyzer memory leak because function runner not close fix:[2.5] analyzer memory leak because function runner not close May 14, 2025
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 14, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 14, 2025
@aoiasd
Copy link
Contributor Author

aoiasd commented May 14, 2025

rerun ut

1 similar comment
@aoiasd
Copy link
Contributor Author

aoiasd commented May 14, 2025

rerun ut

Copy link

codecov bot commented May 14, 2025

Codecov Report

Attention: Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (0ecf999) to head (351ed9c).
Report is 12 commits behind head on 2.5.

Files with missing lines Patch % Lines
.../flushcommon/pipeline/flow_graph_embedding_node.go 0.00% 4 Missing ⚠️
internal/querynodev2/pipeline/embedding_node.go 0.00% 4 Missing ⚠️
...rnal/util/function/multi_analyzer_bm25_function.go 0.00% 4 Missing ⚠️
internal/util/function/bm25_function.go 0.00% 2 Missing ⚠️
internal/datanode/importv2/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41840      +/-   ##
==========================================
- Coverage   80.64%   80.62%   -0.02%     
==========================================
  Files        1427     1427              
  Lines      204821   204940     +119     
==========================================
+ Hits       165174   165239      +65     
- Misses      33843    33888      +45     
- Partials     5804     5813       +9     
Components Coverage Δ
Client 79.42% <ø> (-0.03%) ⬇️
Core 70.67% <ø> (+0.01%) ⬆️
Go 82.59% <11.76%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/util/function/function.go 100.00% <ø> (ø)
internal/util/pipeline/node.go 100.00% <100.00%> (ø)
internal/util/pipeline/pipeline.go 88.37% <100.00%> (+0.27%) ⬆️
internal/datanode/importv2/util.go 64.22% <0.00%> (-0.60%) ⬇️
internal/util/function/bm25_function.go 80.35% <0.00%> (-1.47%) ⬇️
.../flushcommon/pipeline/flow_graph_embedding_node.go 82.00% <0.00%> (-3.42%) ⬇️
internal/querynodev2/pipeline/embedding_node.go 88.73% <0.00%> (-2.58%) ⬇️
...rnal/util/function/multi_analyzer_bm25_function.go 64.90% <0.00%> (-1.77%) ⬇️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aoiasd
Copy link
Contributor Author

aoiasd commented May 14, 2025

rerun ut

@mergify mergify bot added the ci-passed label May 14, 2025
@czs007 czs007 added this to the 2.5.12 milestone May 15, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bb562c6 into milvus-io:2.5 May 15, 2025
25 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants