Skip to content

fix: set conan profile to default #41845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

XTxxxx
Copy link

@XTxxxx XTxxxx commented May 14, 2025

Fix #41844

@sre-ci-robot
Copy link
Contributor

Welcome @XTxxxx! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XTxxxx
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 14, 2025
@sre-ci-robot sre-ci-robot requested review from XuanYang-cn and yhmo May 14, 2025 13:52
Copy link
Contributor

mergify bot commented May 14, 2025

@XTxxxx Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented May 14, 2025

@XTxxxx

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@mergify mergify bot added needs-dco DCO is missing in this pull request. do-not-merge/invalid-pr-format labels May 14, 2025
@XTxxxx XTxxxx changed the title fix 3rdparty build scripts: set conan profile to default fix: set conan profile to default May 14, 2025
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels May 14, 2025
Copy link
Contributor

mergify bot commented May 14, 2025

@XTxxxx E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.70%. Comparing base (2d0ae3a) to head (f260d3a).
Report is 26 commits behind head on master.

❌ Your project check has failed because the head coverage (73.70%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41845       +/-   ##
===========================================
- Coverage   81.64%   73.70%    -7.95%     
===========================================
  Files        1204      335      -869     
  Lines      186101    30637   -155464     
===========================================
- Hits       151949    22582   -129367     
+ Misses      27865     8055    -19810     
+ Partials     6287        0     -6287     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 73.70% <ø> (∅)
Go ∅ <ø> (∅)

see 1539 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Issues or changes related a bug needs-dco DCO is missing in this pull request. size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Conan profile not specified
2 participants