Skip to content

enhance: support balancing multiple collections in single trigger #41875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

weiliu1031
Copy link
Contributor

issue: #41874

  • Optimize balance_checker to support balancing multiple collections simultaneously
  • Add new parameters for segment and channel balancing batch sizes
  • Add enableBalanceOnMultipleCollections parameter
  • Update tests for balance checker

This change improves resource utilization by allowing the system to balance multiple collections in a single trigger with configurable batch sizes.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 15, 2025
@sre-ci-robot sre-ci-robot requested review from bigsheeper and sunby May 15, 2025 10:26
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 15, 2025
Copy link

codecov bot commented May 15, 2025

Codecov Report

Attention: Patch coverage is 96.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.53%. Comparing base (f094d02) to head (cf2bc03).
Report is 53 commits behind head on master.

Files with missing lines Patch % Lines
internal/querycoordv2/checkers/balance_checker.go 93.47% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41875       +/-   ##
===========================================
+ Coverage   73.68%   80.53%    +6.85%     
===========================================
  Files         335     1528     +1193     
  Lines       30620   215812   +185192     
===========================================
+ Hits        22562   173807   +151245     
- Misses       8058    35769    +27711     
- Partials        0     6236     +6236     
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 73.65% <ø> (-0.04%) ⬇️
Go 81.91% <96.25%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/balance/balance.go 91.20% <100.00%> (ø)
...al/querycoordv2/balance/rowcount_based_balancer.go 90.81% <100.00%> (ø)
...ernal/querycoordv2/balance/score_based_balancer.go 95.89% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.40% <100.00%> (ø)
internal/querycoordv2/checkers/balance_checker.go 96.31% <93.47%> (ø)

... and 1202 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Optimize balance_checker to support balancing multiple collections simultaneously
- Add new parameters for segment and channel balancing batch sizes
- Add enableBalanceOnMultipleCollections parameter
- Update tests for balance checker

This change improves resource utilization by allowing the system to balance multiple collections in a single trigger with configurable batch sizes.

Signed-off-by: Wei Liu <[email protected]>
@weiliu1031 weiliu1031 force-pushed the refine_balance_checker branch from 5574ecc to cf2bc03 Compare May 15, 2025 12:02
Copy link
Contributor

mergify bot commented May 15, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label May 16, 2025
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weiliu1031, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4e1208f into milvus-io:master May 21, 2025
19 of 20 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request May 28, 2025
…lvus-io#41875)

issue: milvus-io#41874
pr: milvus-io#41875
- Optimize balance_checker to support balancing multiple collections
simultaneously
- Add new parameters for segment and channel balancing batch sizes
- Add enableBalanceOnMultipleCollections parameter
- Update tests for balance checker

This change improves resource utilization by allowing the system to
balance multiple collections in a single trigger with configurable batch
sizes.

Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request May 28, 2025
…er (#41875) (#42134)

issue: #41874
pr: #41875
- Optimize balance_checker to support balancing multiple collections
simultaneously
- Add new parameters for segment and channel balancing batch sizes
- Add enableBalanceOnMultipleCollections parameter
- Update tests for balance checker

This change improves resource utilization by allowing the system to
balance multiple collections in a single trigger with configurable batch
sizes.

Signed-off-by: Wei Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants