Skip to content

enhance: Set the default GPU version autoindex to use the CAgra index #41906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

presburger
Copy link
Member

@presburger presburger commented May 16, 2025

issue: #41907

@sre-ci-robot sre-ci-robot requested review from bigsheeper and sunby May 16, 2025 11:59
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 16, 2025
@presburger presburger changed the title enhence: Set the default GPU version autoindex to use the CAgra index enhance: Set the default GPU version autoindex to use the CAgra index May 16, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 16, 2025
Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

mergify bot commented May 16, 2025

@presburger go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented May 16, 2025

@presburger E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (22ef03b) to head (44eab3e).
Report is 6 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41906       +/-   ##
===========================================
+ Coverage   73.09%   80.46%    +7.36%     
===========================================
  Files         335     1537     +1202     
  Lines       30724   216553   +185829     
===========================================
+ Hits        22459   174240   +151781     
- Misses       8265    36027    +27762     
- Partials        0     6286     +6286     
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 73.08% <ø> (-0.02%) ⬇️
Go 81.91% <100.00%> (∅)
Files with missing lines Coverage Δ
pkg/util/paramtable/autoindex_param.go 88.14% <100.00%> (ø)
pkg/util/paramtable/autoindex_param_nocuda.go 100.00% <100.00%> (ø)

... and 1204 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@presburger
Copy link
Member Author

rerun go-sdk

@presburger
Copy link
Member Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 19, 2025

@presburger E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

liliuleo

This comment was marked as spam.

liliuleo

This comment was marked as spam.

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label May 22, 2025
@sre-ci-robot sre-ci-robot merged commit e878fe5 into milvus-io:master May 22, 2025
23 of 25 checks passed
liliu-z pushed a commit to liliu-z/milvus that referenced this pull request May 29, 2025
liliu-z pushed a commit to liliu-z/milvus that referenced this pull request May 29, 2025
sre-ci-robot pushed a commit that referenced this pull request May 29, 2025
pr: #41906
issue: #41907

Signed-off-by: yusheng.ma <[email protected]>
Signed-off-by: Li Liu <[email protected]>
Co-authored-by: presburger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants