Skip to content

enhance: Make terminate warning as error #41916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Related to #41219

Make terminate warning as error in compile configuration in case of future noexcept issue

Related to milvus-io#41219

Make terminate warning as error in compile configuration in case of
future `noexcept` issue

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 May 19, 2025 02:34
@sre-ci-robot sre-ci-robot added size/XS Denotes a PR that changes 0-9 lines. area/compilation labels May 19, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 19, 2025
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.58%. Comparing base (3bbc0fa) to head (f886de4).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41916      +/-   ##
==========================================
+ Coverage   80.51%   80.58%   +0.07%     
==========================================
  Files        1528     1528              
  Lines      215818   215954     +136     
==========================================
+ Hits       173757   174035     +278     
+ Misses      35813    35702     -111     
+ Partials     6248     6217      -31     
Components Coverage Δ
Client 79.36% <ø> (ø)
Core 73.64% <ø> (ø)
Go 81.97% <ø> (+0.09%) ⬆️

see 61 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label May 19, 2025
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot removed the ci-passed label May 19, 2025
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants