Skip to content

enhance: add privilege group message types and corresponding tests #41939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented May 20, 2025

@sre-ci-robot sre-ci-robot requested a review from xiaocai2333 May 20, 2025 03:39
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 20, 2025
@sre-ci-robot sre-ci-robot requested a review from yhmo May 20, 2025 03:39
@SimFG SimFG changed the title enhance: [2.5] add privilege group message types and corresponding tests enhance: add privilege group message types and corresponding tests May 20, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 20, 2025
Copy link
Contributor

mergify bot commented May 20, 2025

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented May 20, 2025

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 82.90598% with 20 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (65dd398) to head (48da752).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
pkg/mq/msgstream/msg_for_user_role.go 79.16% 14 Missing and 6 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41939       +/-   ##
===========================================
+ Coverage   73.64%   80.58%    +6.94%     
===========================================
  Files         335     1528     +1193     
  Lines       30692   216108   +185416     
===========================================
+ Hits        22603   174153   +151550     
- Misses       8089    35727    +27638     
- Partials        0     6228     +6228     
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 73.64% <ø> (ø)
Go 81.97% <82.90%> (∅)
Files with missing lines Coverage Δ
internal/proxy/util.go 85.84% <100.00%> (ø)
pkg/mq/msgstream/unmarshal.go 100.00% <100.00%> (ø)
pkg/mq/msgstream/msg_for_user_role.go 80.11% <79.16%> (ø)

... and 1190 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SimFG
Copy link
Contributor Author

SimFG commented May 20, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 20, 2025
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9f866dd into milvus-io:master May 21, 2025
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants