Skip to content

fix sn oom issue during small file loading in wp #41946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2025
Merged

fix sn oom issue during small file loading in wp #41946

merged 1 commit into from
May 22, 2025

Conversation

tinswzy
Copy link
Contributor

@tinswzy tinswzy commented May 20, 2025

#41846 #41894
Resolve SN OOM issue during small file loading in Woodpecker;
Correct WP fence/close execution order;

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/dependency Pull requests that update a dependency file labels May 20, 2025
czs007
czs007 approved these changes May 20, 2025
View reviewed changes
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot added the dco-passed DCO check passed. label May 20, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2025

@tinswzy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (f20e085) to head (f357226).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41946       +/-   ##
===========================================
+ Coverage   73.02%   80.49%    +7.46%     
===========================================
  Files         335     1537     +1202     
  Lines       30700   216705   +186005     
===========================================
+ Hits        22419   174427   +152008     
- Misses       8281    36001    +27720     
- Partials        0     6277     +6277
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 73.02% <ø> (ø)
Go 81.95% <100.00%> (∅)
Files with missing lines Coverage Δ
pkg/streaming/walimpls/impls/wp/builder.go 80.62% <100.00%> (ø)

... and 1201 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tinswzy tinswzy force-pushed the fix_wp_load_smallfiles_oom branch from 09504c8 to b7dd4a6 Compare May 20, 2025 12:15
@sre-ci-robot sre-ci-robot removed the lgtm label May 20, 2025
@tinswzy tinswzy force-pushed the fix_wp_load_smallfiles_oom branch from b7dd4a6 to e6bdf99 Compare May 20, 2025 13:29
@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 20, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

/run-cpu-e2e

1 similar comment
@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

/run-cpu-e2e

1 similar comment
@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

/run-cpu-e2e

@tinswzy tinswzy force-pushed the fix_wp_load_smallfiles_oom branch from e6bdf99 to 75378da Compare May 21, 2025 06:19
@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@tinswzy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

/run-cpu-e2e

@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

rerun cpp-unit-test

@tinswzy
Copy link
Contributor Author

tinswzy commented May 21, 2025

rerun ut

@mergify Mergify
Copy link
Contributor

mergify bot commented May 21, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy tinswzy force-pushed the fix_wp_load_smallfiles_oom branch from 75378da to e4635e8 Compare May 21, 2025 23:05
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2025

@tinswzy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@tinswzy tinswzy force-pushed the fix_wp_load_smallfiles_oom branch from e4635e8 to f357226 Compare May 22, 2025 01:19
@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 22, 2025

/run-cpu-e2e

czs007
czs007 approved these changes May 22, 2025
View reviewed changes
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, tinswzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 22, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented May 22, 2025

@tinswzy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tinswzy
Copy link
Contributor Author

tinswzy commented May 22, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 22, 2025
@sre-ci-robot sre-ci-robot merged commit 1735f55 into milvus-io:master May 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 approved these changes

@congqixia congqixia Awaiting requested review from congqixia

@yanliang567 yanliang567 Awaiting requested review from yanliang567

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. do-not-merge/invalid-pr-format lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tinswzy @sre-ci-robot @czs007