Skip to content

enhance: add delete rows into delete msg header and more metric #41952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented May 20, 2025

issue: #41544

  • add delete rows into delete messsage header
  • add more insert/delete metrics
  • fix non-broadcast message has broadcast header

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 20, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 20, 2025
@chyezh chyezh force-pushed the fix_add_delete_rows_into_header branch from 98cbb03 to be74170 Compare May 20, 2025 09:52
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.46%. Comparing base (8a85bc4) to head (afbd17a).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/flushcommon/pipeline/flow_graph_dd_node.go 14.28% 6 Missing ⚠️
pkg/streaming/util/message/builder.go 60.00% 1 Missing and 1 partial ⚠️
...interceptors/shard/shards/shard_manager_segment.go 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41952       +/-   ##
===========================================
+ Coverage   73.04%   80.46%    +7.42%     
===========================================
  Files         335     1537     +1202     
  Lines       30702   216752   +186050     
===========================================
+ Hits        22425   174407   +151982     
- Misses       8277    36055    +27778     
- Partials        0     6290     +6290     
Components Coverage Δ
Client 79.36% <ø> (∅)
Core 73.02% <ø> (-0.02%) ⬇️
Go 81.92% <83.33%> (∅)
Files with missing lines Coverage Δ
internal/proxy/task_delete_streaming.go 74.00% <100.00%> (ø)
...mingnode/server/wal/adaptor/old_version_message.go 73.02% <100.00%> (ø)
...server/wal/interceptors/shard/shard_interceptor.go 89.58% <100.00%> (ø)
...rver/wal/interceptors/shard/stats/stats_manager.go 90.63% <100.00%> (ø)
...al/streamingnode/server/wal/metricsutil/segment.go 82.14% <100.00%> (ø)
pkg/metrics/streaming_service_metrics.go 100.00% <100.00%> (ø)
pkg/streaming/util/message/adaptor/ts_msg_newer.go 54.76% <ø> (ø)
pkg/streaming/util/message/marshal_log_object.go 79.79% <100.00%> (ø)
pkg/streaming/util/message/message_impl.go 79.91% <100.00%> (ø)
...interceptors/shard/shards/shard_manager_segment.go 76.74% <92.85%> (ø)
... and 2 more

... and 1191 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyezh chyezh force-pushed the fix_add_delete_rows_into_header branch from be74170 to 0ee62f6 Compare May 21, 2025 07:22
@sre-ci-robot sre-ci-robot removed the lgtm label May 21, 2025
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Copy link
Contributor

mergify bot commented May 21, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_add_delete_rows_into_header branch from 0ee62f6 to 7d32e6c Compare May 21, 2025 13:22
Copy link
Contributor

mergify bot commented May 21, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh chyezh force-pushed the fix_add_delete_rows_into_header branch from 7d32e6c to 39d6ef9 Compare May 21, 2025 16:18
- add delete rows into delete messsage header
- add more insert/delete metrics
- fix non-broadcast message has broadcast header

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the fix_add_delete_rows_into_header branch from 39d6ef9 to afbd17a Compare May 22, 2025 02:13
Copy link
Contributor

mergify bot commented May 22, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented May 22, 2025

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented May 22, 2025

rerun ut

@mergify mergify bot added the ci-passed label May 22, 2025
@chyezh chyezh added the lgtm label May 22, 2025
@sre-ci-robot sre-ci-robot merged commit c9b0748 into milvus-io:master May 22, 2025
23 of 25 checks passed
@chyezh chyezh deleted the fix_add_delete_rows_into_header branch May 22, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants