Skip to content

feat: support to drop properties of field #41954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025
Merged

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented May 20, 2025

issue: #41990
pr: #41996

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label May 20, 2025
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 20, 2025
@mergify mergify bot added the dco-passed DCO check passed. label May 20, 2025
Copy link
Contributor

mergify bot commented May 20, 2025

@yhmo Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/feature Issues related to feature request from users labels May 20, 2025
Copy link
Contributor

mergify bot commented May 20, 2025

@yhmo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 83.63636% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.69%. Comparing base (f4e4bb2) to head (6f1c546).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/task.go 80.43% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #41954       +/-   ##
===========================================
+ Coverage   70.70%   80.69%    +9.99%     
===========================================
  Files         308     1427     +1119     
  Lines       29905   205357   +175452     
===========================================
+ Hits        21145   165718   +144573     
- Misses       8760    33824    +25064     
- Partials        0     5815     +5815     
Components Coverage Δ
Client 79.42% <ø> (∅)
Core 70.69% <ø> (-0.02%) ⬇️
Go 82.67% <83.63%> (∅)
Files with missing lines Coverage Δ
internal/rootcoord/alter_collection_task.go 90.54% <100.00%> (ø)
internal/proxy/task.go 84.50% <80.43%> (ø)

... and 1118 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

mergify bot commented May 21, 2025

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented May 21, 2025

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 21, 2025

@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented May 21, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented May 21, 2025

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented May 21, 2025

/run-cpu-e2e

Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented May 27, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit a48001f into milvus-io:2.5 May 27, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants