-
Notifications
You must be signed in to change notification settings - Fork 3.2k
enhance: support TTL expiration with queries returning no results #41960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #41960 +/- ##
==========================================
- Coverage 80.65% 80.64% -0.01%
==========================================
Files 1427 1427
Lines 205136 205320 +184
==========================================
+ Hits 165456 165585 +129
- Misses 33877 33908 +31
- Partials 5803 5827 +24
🚀 New features to boost your workflow:
|
f6c0e96
to
3cd3b9a
Compare
Signed-off-by: Xianhui.Lin <[email protected]> polish Signed-off-by: Xianhui.Lin <[email protected]> polish Signed-off-by: Xianhui.Lin <[email protected]> add test Signed-off-by: Xianhui.Lin <[email protected]>
@JsDove go-sdk check failed, comment |
rerun go-sdk |
Signed-off-by: Xianhui.Lin <[email protected]>
@JsDove E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, JsDove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…lvus-io#41960) support TTL expiration with queries returning no results issue:milvus-io#41959 pr:milvus-io#41720 --------- Signed-off-by: Xianhui.Lin <[email protected]>
…lvus-io#41960) support TTL expiration with queries returning no results issue:milvus-io#41959 pr:milvus-io#41720 --------- Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]>
@@ -84,6 +101,25 @@ TimestampIndex::GenerateBitset(Timestamp query_timestamp, | |||
return bitset; | |||
} | |||
|
|||
BitsetType | |||
TimestampIndex::GenerateTTLBitset(Timestamp collection_ttl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use index to accelerate
…lvus-io#41960) support TTL expiration with queries returning no results issue:milvus-io#41959 pr:milvus-io#41720 --------- Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]> enhancement: query ttl Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]> feat growing Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]> fix Signed-off-by: Xianhui.Lin <[email protected]>
support TTL expiration with queries returning no results
issue:#41959
pr:#41720