Skip to content

enhance: support TTL expiration with queries returning no results #41960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented May 20, 2025

support TTL expiration with queries returning no results
issue:#41959
pr:#41720

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels May 20, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.64%. Comparing base (0e75e66) to head (6b90e43).
Report is 9 commits behind head on 2.5.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
internal/proxy/util.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41960      +/-   ##
==========================================
- Coverage   80.65%   80.64%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      205136   205320     +184     
==========================================
+ Hits       165456   165585     +129     
- Misses      33877    33908      +31     
- Partials     5803     5827      +24     
Components Coverage Δ
Client 79.42% <ø> (ø)
Core 70.69% <90.90%> (+0.01%) ⬆️
Go 82.61% <87.50%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/exec/QueryContext.h 85.71% <100.00%> (+0.52%) ⬆️
internal/core/src/exec/operator/MvccNode.cpp 93.93% <100.00%> (+0.18%) ⬆️
internal/core/src/exec/operator/MvccNode.h 60.00% <ø> (ø)
internal/core/src/query/ExecPlanNodeVisitor.cpp 100.00% <100.00%> (ø)
internal/core/src/query/ExecPlanNodeVisitor.h 100.00% <100.00%> (ø)
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 17.14% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.cpp 83.57% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 69.41% <ø> (ø)
internal/core/src/segcore/SegmentInterface.cpp 86.22% <100.00%> (+0.06%) ⬆️
internal/core/src/segcore/SegmentInterface.h 68.85% <ø> (ø)
... and 14 more

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JsDove JsDove force-pushed the filterttl branch 2 times, most recently from f6c0e96 to 3cd3b9a Compare May 21, 2025 02:59
@mergify mergify bot added the ci-passed label May 21, 2025
Signed-off-by: Xianhui.Lin <[email protected]>

polish

Signed-off-by: Xianhui.Lin <[email protected]>

polish

Signed-off-by: Xianhui.Lin <[email protected]>

add test

Signed-off-by: Xianhui.Lin <[email protected]>
Copy link
Contributor

mergify bot commented May 21, 2025

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented May 21, 2025

rerun go-sdk

@mergify mergify bot added the ci-passed label May 21, 2025
Signed-off-by: Xianhui.Lin <[email protected]>
@mergify mergify bot removed the ci-passed label May 22, 2025
Copy link
Contributor

mergify bot commented May 22, 2025

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented May 22, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 22, 2025
Copy link
Collaborator

@czs007 czs007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0574fc7 into milvus-io:2.5 May 26, 2025
19 of 20 checks passed
JsDove added a commit to JsDove/milvus that referenced this pull request May 26, 2025
…lvus-io#41960)

support TTL expiration with queries returning no results
issue:milvus-io#41959
pr:milvus-io#41720

---------

Signed-off-by: Xianhui.Lin <[email protected]>
JsDove added a commit to JsDove/milvus that referenced this pull request May 26, 2025
…lvus-io#41960)

support TTL expiration with queries returning no results
issue:milvus-io#41959
pr:milvus-io#41720

---------

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>
@@ -84,6 +101,25 @@ TimestampIndex::GenerateBitset(Timestamp query_timestamp,
return bitset;
}

BitsetType
TimestampIndex::GenerateTTLBitset(Timestamp collection_ttl,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use index to accelerate

JsDove added a commit to JsDove/milvus that referenced this pull request May 27, 2025
…lvus-io#41960)

support TTL expiration with queries returning no results
issue:milvus-io#41959
pr:milvus-io#41720

---------

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>

enhancement: query ttl

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>

feat growing

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>

fix

Signed-off-by: Xianhui.Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants