Skip to content

fix: Segment may be released prematurely during balance channel #42043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented May 23, 2025

issue: #41143
pr: #42090

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 23, 2025
Copy link
Contributor

mergify bot commented May 23, 2025

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels May 23, 2025
@weiliu1031
Copy link
Contributor Author

/kind branch-feature

@weiliu1031
Copy link
Contributor Author

related logic has been refactored in master branch by #41937

Copy link
Contributor

mergify bot commented May 23, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.64%. Comparing base (83ca664) to head (9274265).
Report is 20 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #42043      +/-   ##
==========================================
- Coverage   80.65%   80.64%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      205271   205321      +50     
==========================================
+ Hits       165553   165589      +36     
- Misses      33905    33917      +12     
- Partials     5813     5815       +2     
Components Coverage Δ
Client 79.42% <ø> (ø)
Core 70.69% <ø> (+0.02%) ⬆️
Go 82.61% <100.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querycoordv2/checkers/segment_checker.go 95.79% <100.00%> (+6.09%) ⬆️

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 23, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

run-cpu-e2e

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 26, 2025
@weiliu1031 weiliu1031 force-pushed the fix_release_segment_during_balance_channel branch from 2ab9c17 to 0c8f320 Compare May 26, 2025 08:42
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 26, 2025
@mergify mergify bot removed the ci-passed label May 26, 2025
@weiliu1031 weiliu1031 force-pushed the fix_release_segment_during_balance_channel branch from 0c8f320 to 9274265 Compare May 26, 2025 09:01
Copy link
Contributor

mergify bot commented May 26, 2025

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

1 similar comment
Copy link
Contributor

mergify bot commented May 26, 2025

@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels May 26, 2025
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels May 26, 2025
@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label May 26, 2025
@congqixia congqixia added this to the 2.5.13 milestone May 29, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d2ff390 into milvus-io:2.5 May 29, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants