-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: Segment may be released prematurely during balance channel #42043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Segment may be released prematurely during balance channel #42043
Conversation
@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
/kind branch-feature |
related logic has been refactored in master branch by #41937 |
@weiliu1031 E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #42043 +/- ##
==========================================
- Coverage 80.65% 80.64% -0.01%
==========================================
Files 1427 1427
Lines 205271 205321 +50
==========================================
+ Hits 165553 165589 +36
- Misses 33905 33917 +12
- Partials 5813 5815 +2
🚀 New features to boost your workflow:
|
rerun ut |
/run-cpu-e2e |
@weiliu1031 E2e jenkins job failed, comment |
rerun ut |
run-cpu-e2e |
/run-cpu-e2e |
2ab9c17
to
0c8f320
Compare
Signed-off-by: Wei Liu <[email protected]>
0c8f320
to
9274265
Compare
@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
1 similar comment
@weiliu1031 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
rerun ut |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #41143
pr: #42090