fix: Add forceDrop option to DropRole client API #47071
Conversation
Add WithForce method to dropDropRoleOption to support force dropping roles. This fixes the issue where force drop role functionality was not exposed in the client SDK. Signed-off-by: xiaofanluan <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary of ChangesHello @xiaofan-luan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a forceDrop option to the DropRole client API. The implementation is straightforward and follows existing patterns. However, it is missing unit tests for the new functionality, which is a critical part of ensuring code quality. I've added a comment with details on the required tests.
| func (opt *dropDropRoleOption) WithForce(force bool) *dropDropRoleOption { | ||
| opt.forceDrop = force | ||
| return opt | ||
| } |
There was a problem hiding this comment.
This new WithForce method and the associated forceDrop option are not covered by unit tests. It's crucial to add tests to client/milvusclient/rbac_test.go to ensure this new functionality works as expected and to prevent future regressions.
Specifically, you should add test cases to TestDropRole to verify:
- When
WithForce(true)is called, theForceDropfield inmilvuspb.DropRoleRequestis set totrue. - When
WithForceis not called, theForceDropfield defaults tofalse.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #47071 +/- ##
==========================================
- Coverage 76.45% 76.41% -0.05%
==========================================
Files 2016 2016
Lines 325600 325604 +4
==========================================
- Hits 248951 248803 -148
- Misses 68688 68810 +122
- Partials 7961 7991 +30
🚀 New features to boost your workflow:
|
2 participants
issue: #46887