fix: query node timetick metrics : change msg_type from insert to timetick #47082
Conversation
|
Welcome @amaypatil02! It looks like this is your first PR to milvus-io/milvus 🎉 |
Summary of ChangesHello @amaypatil02, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where critical Query Node TimeTick utilization metrics were not being displayed correctly in the Grafana dashboard. By adjusting the message type used in the underlying Prometheus queries, this change ensures that the relevant performance data is now accurately collected and visualized, providing better observability for the Query Node's operation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
|
@amaypatil02 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure: Where Example: Please review and update your PR to comply with these guidelines. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates Grafana dashboard queries for the milvus_querynode_consume_tt_lag_ms metric, changing the msg_type from insert to timetick to resolve an issue where no data was being displayed. The change is logical and addresses the problem described. I have one suggestion to improve clarity: the title of the affected panel should be updated to reflect the new data source, as it currently still refers to 'Insert'.
| }, | ||
| "exemplar": true, | ||
| "expr": "avg(milvus_querynode_consume_tt_lag_ms{app_kubernetes_io_instance=~\"$instance\", app_kubernetes_io_name=\"$app_name\", namespace=\"$namespace\", msg_type=\"insert\"}) by (pod, node_id)", | ||
| "expr": "avg(milvus_querynode_consume_tt_lag_ms{app_kubernetes_io_instance=~\"$instance\", app_kubernetes_io_name=\"$app_name\", namespace=\"$namespace\", msg_type=\"timetick\"}) by (pod, node_id)", |
There was a problem hiding this comment.
While the query is now correctly filtering for msg_type="timetick", the panel's title on line 7390 is still TimeTick Lag Behind Now (Consumed Insert). This is now misleading. To avoid confusion, please update the title to align with the data being shown, for example, to TimeTick Lag Behind Now (Consumed TimeTick) or simply TimeTick Lag Behind Now.
amaypatil02
changed the title
amaypatil02
changed the title
mergify
bot
added
kind/bug
|
@amaypatil02 Please associate the related issue to the body of your Pull Request. (eg. "issue: #") |
Signed-off-by: Amay Patil <[email protected]>
amaypatil02
force-pushed
the
fix/grafana-dashboard-timetick
branch
from
78480df to
e6c0c7c
Compare
mergify
bot
added
dco-passed
amaypatil02
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amaypatil02, yanliang567 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
4 participants
Issue: 47079
Update Query to Fix Query Node TimeTick utilization
Metrics for Query node is not appearing correctly. Query needs to be updated. Already confirmed with James on a separate thread.
Currently, query shows No data.
Post fix, Data is available.