enhance: [2.6] Reduce memory allocations and copies in data loading #47088
+152
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JsonFlatIndex: reuse scratch buffer for nested JSON serialization - ChunkWriter: cache parsed Json objects to avoid double parsing - StringChunkWriter: reuse string_view vector across writes Signed-off-by: Buqian Zheng <[email protected]>
- json_stats/utils: CreateArrowBuilders, CreateArrowSchema, CreateParquetKVMetadata - FunctionFactory: RegisterFilterFunction - IndexMeta: loop variables in ToString and constructor Signed-off-by: Buqian Zheng <[email protected]>
- Add reserve() calls before vector population loops - Use std::move() for rvalue parameters and return values - Move buffer allocations outside hot loops (SubSearchResult) Affected files: FieldData, ArrayOffsets, Schema, Slice, IndexStats, JsonContainsExpr, RescoresNode, PlanProto, SubSearchResult, bson_inverted, parquet_writer, segment_c Signed-off-by: Buqian Zheng <[email protected]>
- ReduceUtils: assign directly to protobuf field without temporary variable - RemoteInputStream: move fsync() outside loop for better I/O efficiency Signed-off-by: Buqian Zheng <[email protected]>
- Call FillFieldData(arrow::StringArray) directly in FieldData.cpp - Fix null handling in FillFieldData by using GetView() instead of iterator Signed-off-by: Buqian Zheng <[email protected]>
Replace dynamic allocation (new uint8_t[]) with stack-allocated arrays to prevent memory leaks when test assertions fail before delete[]. Signed-off-by: Buqian Zheng <[email protected]>
Signed-off-by: Buqian Zheng <[email protected]>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhengbuqian The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
sre-ci-robot
added
the
do-not-merge/need-merge-master-first
Contributor
|
[INFO] PR Label Summary by Default
Use /refresh-label to update related check and label manually |
Contributor
|
@zhengbuqian go-sdk check failed, comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 2.6 #47088 +/- ##
===========================================
+ Coverage 42.57% 76.76% +34.19%
===========================================
Files 12 1910 +1898
Lines 1893 298852 +296959
===========================================
+ Hits 806 229427 +228621
- Misses 1035 62022 +60987
- Partials 52 7403 +7351
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #44452
pr: #46847