-
Notifications
You must be signed in to change notification settings - Fork 3.8k
enhance: add CMEK compatibility validation for snapshot restore #47089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
issue: milvus-io#44358 - Add validateCMEKCompatibility to enforce encryption zone matching during snapshot restore: - Non-encrypted snapshots can only restore to non-encrypted databases - Encrypted snapshots can only restore to databases with matching ezID - Add DescribeDatabase broker method to retrieve target database properties - Fix schema.DbName not being set in RestoreCollection - Fix DbName field missing in convertModelToDesc response Signed-off-by: Wei Liu <[email protected]>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (58.06%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #47089 +/- ##
==========================================
- Coverage 76.56% 76.45% -0.12%
==========================================
Files 2016 2016
Lines 326928 326362 -566
==========================================
- Hits 250316 249521 -795
- Misses 68652 68836 +184
- Partials 7960 8005 +45
🚀 New features to boost your workflow:
|
XuanYang-cn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliu1031, XuanYang-cn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary
Changes
validateCMEKCompatibilityfunction to enforce encryption rules:DescribeDatabasebroker method to retrieve target database propertiesschema.DbNamenot being set inRestoreCollectionDbNamefield missing inconvertModelToDescresponseTest plan
issue: #44358